🚀 go-pugleaf

in article BAD2346B.21A%ChrisH@OvationAdvertising.com, Chris Haas wrote:

> I've been a Basic programmer for 12+ years now and have many VB scripts for ID
> but this is my first AppleScript. I was wondering if someone could take a look
> at this script which relinks all images from LoRes to HiRes and tell me how
> bad it is.
> 
Looks like you're already pretty comfortable with AS to me.

> I just learned AS this weekend and I can't find the VB equivalent of Replace
> so I just made one.
> 
This is the sort of thing text items excel at. Your GetVolumePart handler
(and hence the need for replace) could be done like this:

 set oldDelims to AppleScript's text item delimiters
 set AppleScript's text item delimiters to {":"}
 set theVolume to text item 1 of thePath
 set AppleScript's text item delimiters to oldDelims

You can also parse paths further like this:

 set oldDelims to AppleScript's text item delimiters
 set AppleScript's text item delimiters to {":"}
 set filesName to text item -1 of thePath
 set filesFolder to (text 1 thru text item -2 of thePath) as text
 set AppleScript's text item delimiters to oldDelims

Note the use of -1, to count from the end; you could use that instead of
"length of myOldFilePath" later on.

As long as you don't want case insensitivity, your replace handle4r could be
written as:

on Replace(StringToSearchIn, StringToSearchFor, StringToReplaceWith)
 set oldDelims to AppleScript's text item delimiters
 set AppleScript's text item delimiters to StringToSearchFor
 set StringToSearchIn to text items of StringToSearchIn
 set AppleScript's text item delimiters to StringToReplaceWith
 set StringToSearchIn to (StringToSearchIn as text)
 set AppleScript's text item delimiters to oldDelims
 return StringToSearchIn
end Replace

> I think I could ask the finder to tell me the Volume name instead of manually
> parsing it but I'm a function guy.
> 
And it's often quicker, especially using text item delimiters.

> tell myLink to update
> 
I'm not sure that's necessary.

> set lstAlreadyLinked to lstAlreadyLinked & (name of myLink)
> 
Better to use:

 set end of lstAlreadyLinked to (name of mylink)

It's more memory efficient and quicker.

> The script seems to work beautifully, btw.

That's the main thing.

Cheers,
-- 
Shane Stanley,  sstanley@myriad-com.com.au