🚀 go-pugleaf

Ok, a little time and everything becomes clear - I solved my problem - InDesign changes the order of links as they are updated the updated item is moved to the end, so the item number changes, item 1 is updated, moves to item 45, so then item 2 is item 1 and when you try to grab item 2 you get the old item that was numbered 3.

So I needed to grab the items in reverse order, highest to lowest.

      Sub update_links()
      ' update the links and saves as pdf
      Dim linkcount
      Set myInDesign = CreateObject("InDesign.application.2.0")
      myInDesign.Open ("C:\Indesign\template.indd")
      Set myDocument = myInDesign.ActiveDocument
      linkcount = myDocument.Links.Count
      region_code = "CHI"
      ' loop through all of the links
      For linkloop = linkcount To 1 Step -1
      ' to figure out what path it is on
      currentpath = myDocument.Links.Item(linkloop).Path
      ' replace the market code in the PDF
      currentpath = Replace(currentpath, "WAS", region_code)
      ' change the link
      myDocument.Links.Item(linkloop).Relink (currentpath)
      Set idLink = myDocument.Links.ID(linkloop).Update
      Next
      End Sub

It works like a charm now!
Thanks,
iolaire