🚀 go-pugleaf

Your main problem is that you're still addressing your rectangle when you
get to the layer bit; you need to address the document for getting the
reference to the layer, and the application for setting the active layer of
the active window. You also need to unlock the layer if it already exists.

Try this:

tell application "Adobe InDesign CS2"
    activate
    set myDocument to active document
    set LayerName to "Keyline Box"
    set myPageHeight to page height of document preferences of myDocument
    set myPageWidth to page width of document preferences of myDocument
    --make layer 
    tell myDocument
        try
            -- Does this layer exist ?
            set myLayer to layer LayerName
            -- if so, unlock it
            set the properties of myLayer to {locked:false}
        on error
            -- No? -> create it
            set myLayer to make layer with properties {name:LayerName, layer
color:red, visible:true}
        end try
    end tell
    --make keyline box
    tell myDocument
        tell page 1
            set MyKeylineFrame to make rectangle
            tell MyKeylineFrame
                set the geometric bounds to {"0", "0", myPageHeight,
myPageWidth} -- Needs to fit to the page size
                set the fill color to swatch "None" of myDocument
                set the stroke color to swatch "Black" of myDocument
                set the stroke tint to 100
                set the stroke weight to 1
                set the label to "MyKeylineFrame"
                set item layer to myLayer
                set the properties of myLayer to {locked:true}
            end tell
        end tell
        -- *********************
        -- Here is where I need to select "Layer 1 so I can continue working
by hand, not script"
        set LayerToActive to layer "Layer 1"
    end tell
    set active layer of active window to LayerToActive
    -- *********************
end tell

-- 
Shane Stanley <sstanley@myriad-com.com.au>