🚀 go-pugleaf

Hi John.

I'm not going to answer your question unless I get carried away, but, I do have
some observations about your style of code.  If you are serious about
programming get yourself a copy of Code Complete by Steve McConnel - its the
best discussion of good programming style I've read so far (whether you agree
with has comments or not).

Comment 1 - which will not help you in anyway
---------------------------------------------
Firstly, its well worth making your braces line up.  I personally hate the Java
style

try {
}
catch {
}

and much prefer

try
{
}
catch
{
}

as I find it much clearer.  That's a personal preference, but which ever style
of bracing you choose be consistent about it.  It makes debugging programs much
easier.

Comment 2 - which may help you (I've just spotted your problem I think)
-----------------------------
You spend a lot of time within a while loop changing the value of a flag which
then controls what happens within the loop.  This style of coding is really hard
to maintain and it can be very difficult to see what is going on (as you have
found as your code doesn't work and you can't see why

You are obviously trying to find keywords enclosed in '<' and '>' characters, so
it would seem reasonable to create a new method on the class which is called
once a '<' character was found to read in the keyword stopping either at the end
of the file (probably error condition), or, when a '>' was encountered.

Comment 3 - Of less help than the others
----------------------------------------
Calling a class junk.java doesn't exactly put you in a good frame of mind to
write quality code.

Cheers,
Darren

--
www.soft.net.uk/briarlea
www.salmon.ltd.uk