🚀 go-pugleaf

>ADOQuery->Parameters->Items[0]->Assign(NULL);
I do not think it will work, use ADOQuery->Parameters->Items[0]->Value =
Null();

Null() is from Variants.hpp.

>cmdText = "SELECT * FROM Picture ";
cmdText = "SELECT PictureBlob FROM Picture

Get only field you really need.

>      ADOQuery->Open();
>      ADOQuery->Active = true;
This is the same, use one of these lines.

>   TBlobField* myBlob = (TBlobField*)ADOQuery->FieldByName
("PictureBlob");
>    if(myBlob->IsBlob())
>    ...
You check IsBlob() after casting to TBlobField. You may want to use TField*
myBlob = ..., then check IsBlob(). Check also for IsNull. You may want to
clear picture if not IsBlob or IsNull.

>char* temp = new char[MAX_PATH];
Never used.

----------------------------------------------------------------
Regards,
Viatcheslav V. Vassiliev
http://www.oledbdirect.com
The fastest way to access MS SQL Server, MS Jet (MS Access)
and Interbase (through OLEDB) databases.


"lance" <palat_l@tdipower.com> �������/�������� � �������� ���������:
news:3e755596$1@newsgroups.borland.com...
>
> The following code works, but I would like to run it
> past someone knowledgeable for a bit of a critique.
> Basically, I am inserting an image into a database record,
> then later retrieving an image.
>
> The image is shown and saved from a TImage.
>
> Thanks inadvance for your comments.
>
> //---------------------------------------------------------------
> void __fastcall TMainForm::InsertBtnClick(TObject *Sender)
> {
>   AnsiString cmdText;
>
>   cmdText = "INSERT INTO Picture ";
>   cmdText = cmdText + "(PictureNumber,PictureBlob) VALUES (";
>   cmdText = cmdText + Edit1->Text + ",:pic)";
>
>   ADOQuery->Active = false;
>   ADOQuery->SQL->Clear();
>   ADOQuery->SQL->Add(cmdText);
>
>   if(Image1->Picture != NULL)
>     ADOQuery->Parameters->Items[0]->Assign(Image1->Picture);
>   else
>     ADOQuery->Parameters->Items[0]->Assign(NULL);
>
>   try
>   {
>      ADOQuery->ExecSQL();
>   }
>   catch(...)
>   {
>       ShowMessage("error in database insert: " + cmdText);
>   }
>
> }
> //---------------------------------------------------------------
> void __fastcall TMainForm::RetrieveBtnClick(TObject *Sender)
> {
>   AnsiString cmdText;
>   char* temp = new char[MAX_PATH];
>
>   Image1->Picture = NULL;
>
>   cmdText = "SELECT * FROM Picture ";
>
>   ADOQuery->Active = false;
>   ADOQuery->SQL->Clear();
>   ADOQuery->SQL->Add(cmdText);
>
>   try
>   {
>      ADOQuery->Open();
>      ADOQuery->Active = true;
>   }
>   catch(...)
>   {
>       ShowMessage("error in database select: " + cmdText);
>       return;
>   }
>
>   TBlobField* myBlob = (TBlobField*)ADOQuery->FieldByName
("PictureBlob");
>    if(myBlob->IsBlob())
>     Image1->Picture->Assign(myBlob);
> }
> //---------------------------------------------------------------
>