🚀 go-pugleaf

Hello, Arnie !

 AM> We use NUMBER(10) and have no problem with signed values.

Yes, with NUMBER(10) there is no problem because it mapped to TBCBField.

In ADODB file, in InternalInitFieldDefs procedure there is code:

if (F.Type_ = adNumeric) and (F.NumericScale = 0) and
    (F.Precision < 10) then
          FieldType := ftInteger;

So, BCD fields with precision less then 10 are treated as integer fields.
I do not know for what reason does Borland use this trick (in BCB5 all
adNumeric fields are mapped to BCB), but it allows me to use same
code to work with both Oracle and Sybase databases. I have SMALLINT
and INTEGER columns in Sybase, and without this trick get "Type mismatch,
expected smallint, actual BCD" error when opening query to Oracle.

Problem is that in another place in ADODB file, in
TCustomADODataSet.GetFieldData procedure it is written:

with tagVariant(Data) do
  case Field.DataType of
...
    ftAutoInc, ftInteger:
      Integer(Buffer^) := lVal;

That is not correct, because in case with Oracle NUMBER(9) field, Variant
variable containing field value has type vtInterface and lVal member can
not be used to get integer value. I think that VariantChangeTypeEx must
be called here.

Now the only way I see is to change all ADOQuery components to my class
inherited from TCustomADODataSet and override GetFieldData method. Problem
is in my bad Pascal knowlege.

May be there is easier workaround ?

--
Regards, Victor