🚀 go-pugleaf

One suggestion... get the TField pointers out first using FieldByName and
then
use those TField pointers to set the data and not FieldByName every time...
that
will most defenetively speed up your program...

like this:


TADOTable* const table( DataModule1->ADOTable1 );
TField* const fld_level( table->FieldByName("Level") );
TField* const fld_term( table->FieldByName("Term") );
TField* const fld_bt( table->FieldByName("BT") );
...
{
    table->Append();
    fld_level->AsInteger = ...;
    fld_term->AsString = ...;
    fld_bt->AsString = ...;
    ...
}

(This is a wild guess as I don't know the exact way you're connecting
to your database:) I would suggest against using server side cursors...
or directly changing the data in the database with each line. Use server
side cursors if the amount of data is too big for your client, but in that
case use batch updates.

HTH,
    Jurko

"M. Noroozi Eghbali" <galaxy@irandoc.ac.ir> wrote in message
news:3d021be7_2@dnews...
> Hi,
>
> I am using an ADOTable and a DataSource (Microsoft.Jet.OLEDB.4.0) to save
my
> database in an Access file. It has about 25 fields and none of them are
> indexed. The number of records is about 60000. When I start the saving to
> the Access file, in the first second about 100 records were saved. The
> saving speed gradually decreases inasmuch as after 15000 records the
saving
> speed reaches to maximum 1 record per second. I wrote the code of the
saving
> function here. please tell me what is the wrong.
>
> Regards,
> Mehrdad
>
> void __fastcall TForm1::Save(TTreeNode *Node)
> {
>  typedef CNodeData* PNodeData;
>      TTreeNode *ChildNode;
>
>  do
>      {
>       DataModule1->ADOTable1->Append();
>           DataModule1->ADOTable1->FieldByName("Level")->AsInteger =
> Node->Level;
>           DataModule1->ADOTable1->FieldByName("Term")->AsString =
> Node->Text;
>           DataModule1->ADOTable1->FieldByName("BT")->AsString =
> PNodeData(Node->Data)->BT;
>           DataModule1->ADOTable1->FieldByName("NT")->AsString =
> PNodeData(Node->Data)->NT;
>           DataModule1->ADOTable1->FieldByName("RT")->AsString =
> PNodeData(Node->Data)->RT;
>           DataModule1->ADOTable1->FieldByName("SN")->AsString =
> PNodeData(Node->Data)->SN;
>           DataModule1->ADOTable1->FieldByName("UF")->AsString =
> PNodeData(Node->Data)->UF;
>           DataModule1->ADOTable1->FieldByName("Translate1")->AsString =
> PNodeData(Node->Data)->Translate1;
>           DataModule1->ADOTable1->FieldByName("Translate2")->AsString =
> PNodeData(Node->Data)->Translate2;
>           DataModule1->ADOTable1->FieldByName("Translate3")->AsString =
> PNodeData(Node->Data)->Translate3;
>           DataModule1->ADOTable1->FieldByName("Hide")->AsBoolean =
> PNodeData(Node->Data)->Hide;
>           DataModule1->ADOTable1->FieldByName("Status")->AsInteger =
> PNodeData(Node->Data)->Status;
>           DataModule1->ADOTable1->FieldByName("InputDate")->AsString =
> PNodeData(Node->Data)->InputDate;
>           DataModule1->ADOTable1->FieldByName("ApprovalDate")->AsString =
> PNodeData(Node->Data)->ApprovalDate;
>           DataModule1->ADOTable1->FieldByName("LastUpdate")->AsString =
> PNodeData(Node->Data)->LastUpdate;
>           DataModule1->ADOTable1->FieldByName("NotValidDate")->AsString =
> PNodeData(Node->Data)->NotValidDate;
>           DataModule1->ADOTable1->FieldByName("ABB")->AsString =
> PNodeData(Node->Data)->ABB;
>           DataModule1->ADOTable1->FieldByName("SC")->AsString =
> PNodeData(Node->Data)->SC;
>   DataModule1->ADOTable1->FieldByName("HN")->AsString =
> PNodeData(Node->Data)->HN;
>   DataModule1->ADOTable1->FieldByName("SF")->AsString =
> PNodeData(Node->Data)->SF;
>   DataModule1->ADOTable1->FieldByName("CA")->AsString =
> PNodeData(Node->Data)->CA;
>   DataModule1->ADOTable1->FieldByName("EC")->AsString =
> PNodeData(Node->Data)->EC;
>   if(PNodeData(Node->Data)->Frequency.IsEmpty())
>            DataModule1->ADOTable1->FieldByName("Frequency")->AsInteger =
0;
>           else
>            DataModule1->ADOTable1->FieldByName("Frequency")->AsInteger =
> StrToInt(PNodeData(Node->Data)->Frequency);
>           DataModule1->ADOTable1->FieldByName("Description")->AsString =
> PNodeData(Node->Data)->Description;
>
>           DataModule1->ADOTable1->Post();
>
> ...
> //Some codes to obtain next record from memory.
> ...
>
>      }while(Node);
> }
>
>