🚀 go-pugleaf

The following method loops through records and fields in each record in an
_Recordset*, and copies the data to a TDataSet.  I'm trying to speed it up
as much as possible, and this is the version I've come up with.  Can anybody
make it faster?

/***************************************************************************
****
 * Method:  LoadDataSet
 * Inputs:  TDataSet* - records will be added to this
 *          _Recordset* - data will be copied from this to the TDataSet
 * Outputs:
 * Purpose: Copies recordsets from a _RecordSet* to a TDataSet*
 *          Must call CreateDataSet before calling this

****************************************************************************
**/
int LoadDataSet(TDataSet* pDataSet, _Recordset* prs)
{
    try
    {
        /* Turn off Dataset events and control updates*/
        DataSetEvents evtOldEvents = DataSetEventsOff(pDataSet);
        pDataSet->DisableControls();

        /*Pointers*/
        _di_Fields p_RecordsetFields;
        _di_Field p_RecordsetField;

        /* Recordset field count, record count
        int i_RecordsetFieldCount;
        int i_RecordsetRecCount;

        prs->Get_Fields(p_RecordsetFields);
        p_RecordsetFields->Get_Count(i_RecordsetFieldCount);
        prs->Get_RecordCount(i_RecordsetRecCount);

        /* TDataSet pointers*/
        TField* pDataSetField;
        TFields* pDataSetFields = pDataSet->Fields;

        /* Vars for loops (faster to declare once and use in loop*/
        OleVariant Val;
        int iRecordSetFieldIndex;

        prs->MoveFirst();
        /*Copy each row*/
        for ( int i_RecordsetRow = 0; i_RecordsetRow < i_RecordsetRecCount;
i_RecordsetRow++)
        {
            pDataSet->Insert();
            /*Copy each field*/
            for (iRecordSetFieldIndex = 0; iRecordSetFieldIndex <
i_RecordsetFieldCount; iRecordSetFieldIndex++)
            {
                /* Get the Field name from the TDataSet*/
                pDataSetField =
pDataSetFields->Fields[iRecordSetFieldIndex];

p_RecordsetFields->Get_Item(iRecordSetFieldIndex,p_RecordsetField);
                p_RecordsetField->Get_Value(Val);
                pDataSetField->AsVariant = TVariant(Val);
            }
            prs->MoveNext();
            pDataSet->Post();
        }
        DataSetEventsOn(pDataSet,evtOldEvents);
        pDataSet->EnableControls();
 }
   catch(Exception &e)
   {
     throw Exception(e.Message);
   }
    return 1;
}