🚀 go-pugleaf

> void fnGetFields(TObject* objData,TFields& Fields)
> {
>    try {
>       Fields = ((TADODataSet*)objData)->Fields;
>    } catch (...) {
>    }
> }

This won't work because you are trying to assign a TFields* to a a TFields
reference. The correct syntax would be

Fields = *(((TADODataSet*)objData)->Fields);

I'm not sure this will compile either though. In general, you must always
refer to VCL objects by pointer.

Another quick comment, why does this routine take a TObject for a parameter?
Why not take a TADODataSet, or better yet, a TDataSet? Actually, I don't
understand the purpose of this function, since you could just dereference
the Fields property instead of calling your routine. I will assume that you
have a good reason.

> For:
> // tb is Private Object
> // ls is ListBox
> TFields    fFields;
> TField     fField;

These will cause problems because you aren't using pointers for these vcl
objects. All VCL objects must be created on the heap, not on the stack.

> for (int i = 0;i < fFields->Count;i++)

This won't compile because you are using -> to dereference fFields, but
fFields is not a pointer. The solution of course, based on my previous
comment, is to make fFields a pointer.


> TField* fnGetField(TObject* objData,char* cField)
> {
>    TField* fField;
>    try {
>       fField = ((TADODataSet*)objData)->FieldByName(cField);
>    } catch (...) {
>    }
>    return(fField);
> }

This code is not exception safe because you don't initialize fField to
something reasonable. If an exception occurs, the return value from this
routine is garbage. I suggest that initialize fField to 0 or NULL.

Note: the compiler errors regarding invalid pointer addition are probably
due to the for loop using -> on something that is not a pointer.

Harold Howe [TeamB]
http://www.bcbdev.com