🚀 go-pugleaf

"Gene Buckle" <geneb@grumble.deltasoft.com> wrote in message 
news:4845a18d@newsgroups.borland.com...

> Is this, or is this not the correct way to use TIdTCPClient:

In general, yes.  But earlier you showed that you are using it inside of a 
classSimulator class.  I'm more interested in seeing how THAT class is being 
used.  In particular, you also showed a call to ShowMessage(), but you did 
not indicate WHERE that was being called from exactly.  Can you please 
provide a concrete compilable code snippet that demonstrates your problem in 
a reproducable way?

> #include <IdIOHandlerStream.hpp>

Get rid of that one.  You are not using it anymore.

> Client->Connect();
> connected = Client->Connected();

If Connect() fails, it will raise an exception.  You do not need to call 
Connected() immediately after Connect().

> FYI, attached is the only copy I have of the code that still shows
> the use of the TIdTCPClient component before I tore it out:

But you did not show how the classSimulator itself was being used.

> bool init_done;

You should always intialize your globals.

    bool init_done = false;

> void __fastcall classSimulator::InitCommSystem() {
>    if (!init_done) {
>        busy = true;
>        TCPClient = new TIdTCPClient(NULL);
>        TCPClient->OnDisconnected = MainForm->DisconnectHandler;
>
>        busy = false;
>        init_done = true;
>    }
> }

Where is TCPClient actually declared?  Is it global, or is it a member of 
classSimulator?  Where is InitCommSystem() being called from?

>    } catch (Exception &ex) {

You should always catch exceptions by 'const' reference instead:

    } catch (const Exception &ex) {

>    if (TCPClient->Connected()) {
>       TCPClient->Disconnect();

You don't need to call Connected() first.

> void __fastcall classSimulator::CloseCommSystem() {
>    TCPClient->Free();
> }

Where is CloseCommSystem() called from?

Never call Free() directly.  Use 'delete' instead, especially since you used 
'new' to allocate it.  And be sure to reset your pointer back to NULL as 
well:

    void __fastcall classSimulator::CloseCommSystem()
    {
        delete TCPClient;
        TCPClient = NULL;
    }


Gambit