🚀 go-pugleaf

DreamChaser wrote:

>Thanks for the shout out Bob, but I haven't gotten IP_OPT_RR to work 
>yet. Using the pseudo code that Gambit provided I am still getting an 
>Options Bad error from IcmpSendEcho().

>if( IcmpSendEcho(icmp, addr, SendData, strlen(SendData), &info, reply, ReplySize, 1000) > 0 )

1) You don't check if icmp is valid.
2) You pass unitialized addr.
3) You overflow info.Ttl.
4) It might be objecting to the additional IP_OPT_EOL option
	following the IP_OPT_RR option.

In addition,
5) ReplyBuffer and ReplySize are too small.
	See what else ReplyBuffer needs to hold:
	http://msdn.microsoft.com/en-us/library/aa366050(VS.85).aspx
	Reply.Data is a pointer past the end of the used array
	of ICMP_ECHO_REPLY. It is your memory, not the systems.
I think ReplyBuffer should be (at minimum)
	sizeof(ICMP_ECHO_REPLY)+sizeof(options)+sizeof(SendData)+8;

>1     HANDLE icmp = IcmpCreateFile();
>     IPAddr addr;
>     char *SendData = "Hello";
>
>2    ipaddr.S_un.S_addr = inet_addr("74.125.47.147");
>
>     BYTE options[sizeof(RecordRouteOption)+1] = {0};
>
>     PRecordRouteOption option = (PRecordRouteOption) options;
>
>4    (++option)->type = IP_OPT_EOL;
>
>     IP_OPTION_INFORMATION info = {0};
>3     info.Ttl = 256;
>