🚀 go-pugleaf

Hi Remy,

the last modification you made in IdTCPConnection::ReadStream breaks 
existing code of my application. I'm not sure if it is intended by the 
new design or is simply a bug. Maybe you could take a look at.

// RLebeau - don't call Connected() here!  ReadBuffer() already
// does that internally. Calling Connected() here can cause an
// EIdConnClosedGracefully exception that breaks the loop
// prematurely and thus leave unread bytes in the InputBuffer.
// Let the loop catch the exception before exiting...
while {Connected and} (LWorkCount > 0) do begin
   i := Min(LWorkCount, LBufSize);
   //TODO: Improve this - dont like the use of the exception handler
   //DONE -oAPR: Dont use a string, use a memory buffer or better yet 
the buffer itself.
       try
         try
           ReadBuffer(LBuf[0], i);
         except
           on E: Exception do begin
             // RLebeau - ReadFromStack() inside of ReadBuffer()
             // could have filled the InputBuffer with more bytes
             // than actually requested, so don't extract too
             // many bytes here...
             i := Min(i, InputBuffer.Size);
             Move(InputBuffer.Memory^, LBuf[0], i);
             InputBuffer.Remove(i);
             if not (E is EIdConnClosedGracefully) or not 
AReadUntilDisconnect then begin
               raise;
             end;
           end;

--------

My app (TIdHTTP) allways gets into an infinite loop at the code shown. 
When running with the debugger an EIdConnClosedGracefully exception is 
thrown endless but the loop is never left. The server is a TIdHTTPServer 
descendant. Any ideas how to fix this? The previous version of 
IdTCPConnection does not show this problem.

Thanks.
Regards,
Frank.