🚀 go-pugleaf

Raffaele Pantaleoni <pantaraf@yahoo.it> wrote:

>    Msg=AThread->Connection->ReadLn("",5);

You did not specify any terminator.  Indy will use LF by default.  If the client sends lots of data without sending LF then you could be filling up memory.

Also, you specified a 5-millisecond timeout, but are not using the ReadLnTimedOut property afterwards.  Indy is best used when you let its operations block without timeouts, especially when using any of Indy's multithreaded components  Use timeouts only when you actually need to, and know how to handle them.

>  catch (Exception &exception)

If an Indy exception occurs (one that is derived from EIdException), you should re-throw the exception so that the server knows that something went wrong with the connection.  If you do not do that, or if you do not disconnect the connection manually, then the thread will never terminate properly.

For example:

    void __fastcall TForm1::tcpServerExecute(TIdPeerThread *AThread)
    {
        AnsiString Msg;
        try
        {
            Msg = AThread->Connection->ReadLn();
        }
        catch(const Exception &exception)
        {
            ExceptionsLog("tcpServerExecute", exception.Message);
            if( exception->InheritsFrom(__classid(EIdException)) )
                throw;
        }
    }

> The system memory is still avalaible when the error
> come out, and the process itself hasn't growth in
> memory size.

When the VCL runtime is allocating a string, a memory exception can be thrown without any actual memory actually being allocated if the runtime can determine ahead of time that the new string length is too large for memory to satisfy.


Gambit