🚀 go-pugleaf

Jonathan Benedicto wrote:

 >     DataLength = min( Socket->ReceiveLength(), Data->Length );

If receivelength() > then Data->Length then your code will not read all
available bytes. Your code has to do that though otherwise your program
will hang.

>         char *Buffer = new char[ DataLength ];
> 
>         Socket->ReceiveBuf( Buffer, DataLength );
>         Data->DataStream->Write( Buffer, DataLength );
> 
>         delete[] Buffer;

You don't need to declare a temporary buffer. Just receive directly
in the TMemoryStream and care for a sufficient Size:

   int receivelength = Socket->ReceiveLength();

   if ( receivelength <= 0 )
       return;

   if ( MemoryStream->Position + receivelength >= MemoryStream->Size )
      MemoryStream->Size += receivelength + 1; // +1 is not needed I think

   int nread = Socket->ReceiveBuf (
	((char*)MemoryStream->Memory) + MemoryStream->Position, receivelength );


>     if( Data->Length == 0 )
>     {
>         // process your command here.
>         // it is stored in Data->DataStream.
>         // the stream is cleared once you've finished.

If you check for Data->Length == 0 then you are not allowing the sender
to send more than one message at a time. If the sender sends more
messages at once than the second message can have partly come in with
the first message. Better check if a complete message came in.
You then cannot automatically clear the stream also because of a next message
already partly present.

Hans.