🚀 go-pugleaf

"Hans Galema" <notused@notused.nl> wrote in message
news:43672a80$1@newsgroups.borland.com...

> The adjusting of Size is needed.

Adjusting the Size in general is needed, of course.  That is not what I was
arguing against.  The way that you are doing it is not needed.  You don't
need to check whether the (Position + receivelength) will exceed the current
Size.  Partly because that condition will always be true.  Partly because
the Size already does the validation internally so there is no need to
manually duplicate what TMemoryStream is already doing for you
automatically.  And Partly because your use of the '+=' operator is wrong
anyway.  You cannot use the '+=' operator with properties, it doesn't work
correctly.

These lines are unnecessary:

    if ( MemoryStream->Position + receivelength >= MemoryStream->Size )
        MemoryStream->Size += receivelength + 1; // +1 is not needed I think

All that is needed is the following:

    MemoryStream->Size = MemoryStream->Size + receivelength;

If you really want to continue checking the Position beforehand, then you
need to fix your assignment of the Size property, because you are setting it
to the wrong value.  It should be more like like this instead:

    MemoryStream->Size = (MemoryStream->Position + receivelength);

> If ->Memory had not sufficiend Size then above statement, that
> puts bytes directly in the Memory-buffer, would produce a bufferoverflow.

That is not the point I was arguing.  Of course the Size has to be
sufficient before reading into it.  But you are performing unnecessary
operations in regards to it.


Gambit