🚀 go-pugleaf

Remy Lebeau (TeamB) wrote:
> 
> You are using the TIdICMPClient component, which uses a RAW socket 
> internally (as opposed to using a TCP or UDP socket).  Admin rights are 
> required in order to use RAW sockets on NT4 onwards (which means your code 
> should not have worked on XP, either, unless you are running as an admin). 
> Of course, Microsoft circumvents its own rules by allowing icmp.dll to use 
> RAW sockets without admin rights.
> 

Yes, I am running as an administrator under XP and Vista.

> 
> Rather than casting, you could disable range checking itself for 
> NewSocketHandle().  Indy does this in a couple of other places, for example:
> 
>     function TIdStackBSDBase.NewSocketHandle(const ASocketType: 
> TIdSocketType;
>         const AProtocol: TIdSocketProtocol;
>         const AIPVersion: TIdIPVersion = ID_DEFAULT_IP_VERSION;
>         const AOverlapped: Boolean = False): TIdStackSocketHandle;
>     begin
>         {$IFOPT R+}
>         {$DEFINE RestoreRangeCheckingON}
>         {$R-}
>         {$ENDIF}
>         Result := CheckForSocketError(WSSocket(IdIPFamily[AIPVersion], 
> ASocketType, AProtocol, AOverlapped));
>         {$IFDEF RestoreRangeCheckingON}
>         {$R+}
>         {$UNDEF RestoreRangeCheckingON}
>         {$ENDIF}
>     end;
> 

This would also disable the other range check done during the call of 
WSSocket(). I'm don't think that is needed, and it should probably be 
left until it is known to cause a problem.

> 
>> I also suspect this same error may exist in other places in the code.
> 
> Actually, it doesn't.  Everywhere else that calls CheckForSocketError() 
> passes it an Integer.
> 

Good to hear.

> 
> Since CheckForSocketError() is expecting an Integer error code, not a 
> TSocket handle, I would suggest changing TIdStackBSDBase.NewSocketHandle() 
> to the following instead:
> 
>     function TIdStackBSDBase.NewSocketHandle(const ASocketType: 
> TIdSocketType;
>         const AProtocol: TIdSocketProtocol;
>         const AIPVersion: TIdIPVersion = ID_DEFAULT_IP_VERSION;
>         const AOverlapped: Boolean = False): TIdStackSocketHandle;
>     begin
>         Result := WSSocket(IdIPFamily[AIPVersion], ASocketType, AProtocol, 
> AOverlapped);
>         if Result = Id_INVALID_SOCKET then begin
>             RaiseLastSocketError;
>         end;
>     end;
> 

Thanks Remy. I will make this change in my local source file. Will this 
also be changed in the Indy SVN source, or will I have to apply a patch 
to future downloads?

Dennis Cote