🚀 go-pugleaf

"Roberto Zais" <rzaiss@tiscali.it> wrote in message
news:42e010be$1@newsgroups.borland.com...

> [Rarely I notice  errors, They are rare but persistent ..( Connection
> refused)

"Connection refused" means that either 1) the server is not running, or 2)
it has too many pending client requeusts and can't accept anymore until it
handles the ones that are already pending.

> TCPClient->ReadTimeout = 100;            //READ_STACK_TIMEOUT;

Why are you setting that every time the function is called?  You don't need
to.  Just set it once before calling Connect().  Or better yet, don't set it
at all.  Pass your timeout to ReadFromStack() directly instead of
IdTimeoutDefault.

>         if(TCPClient->InputBuffer->Size  == 0 )
>                 size_readable =
> TCPClient->ReadFromStack(true,IdTimeoutDefault,true);
>               else
>                 size_readable = TCPClient->InputBuffer->Size;
>         }

>        catch(Exception& e){       // Without display

Always catch exception by 'const' references:

    catch(const Exception& e){       // Without display

>           String sbuf = String(e.ClassName()) + " " + e.Message.c_str();

Don't use c_str() like that:

    String sbuf = String(e.ClassName()) + " " + e.Message;

>           if (String(e.ClassName()) == "EIdReadTimeout")
>                   return;                 // lets in waiting read loop

That is not a good way to handle exception testing.  If you want to know if
an exception is a particular class type, then you should be using
dynamic_cast instead:

    if (dynamic_cast<EIdReadTimeout*>(&e) != NULL )

Better would be to catch the specific exception type directly instead:

    catch(const EIdReadTimeout &)
    {
        return;
    }

Better would be to not throw an exception at all.  Specify False instead of
True for the ARaiseExceptionOnTimeout parameter of ReadFromStack().  That is
what the earlier code sample was doing.

>     if(ser_start <= ser_end)
>                                             // circular buffer
>          size = Min((ser_end + MAX_BUF - ser_start),size_readable);
>             else
>                                             // buffer disposto linearmente
:
>                                             // spazio libero = semplice
> differenza puntatori
>          size = Min((ser_end - ser_start),size_readable);    // al limite,
> zero

How EXACTLY are your packets actually formatted?  It doesn't look like you
are taking the advice of the earlier code sample:

    "I would strongly recommend that you prefix your packets with the actual
size of the packets.  Then you don't have to limit your buffer size during
reading, and can send small and large packets alike"

>     TCPClient->ReadBuffer(buf, size);
> // are possible any errors in this phase  ???

No, if the InputBuffer actually has the specified number of bytes available.
If it doesn't, then it has to call ReadFromStack() again (as well as
CheckForDisconnect()) to read more bytes, and that can potentially throw
exceptions.


Gambit