🚀 go-pugleaf

"Remy Lebeau (TeamB)" <no.spam@no.spam.com> wrote in message 
news:42727b69$1@newsgroups.borland.com...
>
> UpdateCompletionPort() is not a Win32 API function, so I assume it 
> is one of
> your own.  What does it look like?

PPER_SOCKET_CONTEXT UpdateCompletionPort(SOCKET sd, IO_OPERATION 
ClientIo, bool bAddToList)
{
PPER_SOCKET_CONTEXT lpPerSocketContext;

lpPerSocketContext = CtxtAllocate(sd, ClientIo);
if( lpPerSocketContext == NULL )
    return NULL;

g_hIOCP = CreateIoCompletionPort((HANDLE)sd, g_hIOCP, 
(DWORD_PTR)lpPerSocketContext, 0);
if( g_hIOCP == NULL ) {
    mycprintf("CreateIoCompletionPort() failed: %d\n", 
GetLastError());
    if(lpPerSocketContext->pIOContext)
    xfree(lpPerSocketContext->pIOContext);
    xfree(lpPerSocketContext);

    return NULL;
}

if( bAddToList )
    CtxtListAddTo(lpPerSocketContext);

if( g_bVerbose )
    mycprintf("UpdateCompletionPort: Socket(%d) added to IOCP\n", 
lpPerSocketContext->Socket);

return lpPerSocketContext;
}

> You should be checking for WSA_IO_PENDING, not ERROR_IO_PENDING.

I'll fix this, thank you.

> You are making the assumption that the "greeting" was already sent, 
> without
> first waiting for the overlapped I/O to actually complete first.

I'll change this to "Send posted.".

> For that matter, why are you using overlapped I/O on your socket to 
> begin
> with?

Because I'm building this server to handle 100's of simulatenous 
connections.

> Also, just for the record, your use of exception handling is 
> horrible in
> these code snippets of yours.  You are leaking a lot of resources 
> when you
> decide to throw your exceptions because you are not closing/freeing
> resources you allocated beforehand.

Thank you for this info. I'll fix that also.