🚀 go-pugleaf

qyte wrote:

> void __fastcall TForm1::Send_fdata(char *ph)

> 
> the code above works pretty good.

But that is not good enough. Reason: bad checking for
the return value of SendBuf. If you ask SendBuf to send
40.000 bytes then it may only send 8192 so it returns 8192.
You have to check that.

Further Send_fdata is a memberfunction of Form1
so you do not need to specify

    Form1->sock[1]-> ...  every time.

    sock[1]->

would do. But then the use of sock[1] is not
very good too. Better give your function an extra parameter:

void __fastcall TForm1::Send_fdata(TCustomWinSocket *Socket, char *ph)
{
         TSearchRec sr;
         int t;
         t=FindFirst(AnsiString(ph)+"\\*.*",faDirectory,sr);
         if(sr.Name.SubString(1,1)==".")
         {
                 FindNext(sr);
                 t=FindNext(sr);
         }
         ffiles="";
         FDATA="";
         int file=0;
         int w=-1;
         while(t==0)
         {
                 if(sr.Name=="AUTOEXEC.BAT" || sr.Name=="CONFIG.SYS")
                 {
                         t=FindNext(sr);
                         continue;
                 }
                 if((sr.Attr & faDirectory)==0)
                 {
                         file++;
                         ffiles+=sr.Name+"*0"+AnsiString(sr.Size)+"?";
                 }
                 else
                 {
                         FDATA+=sr.Name+"*1";
                 }
                 t=FindNext(sr);
         }
         FindClose(sr);
         if(file>0)
                 FDATA+=ffiles;
         FDATA+="\0";
         fData=FDATA.c_str();
         int sz=FDATA.Length();
         sz++;

         while(Socket->SendBuf(&w,sizeof(int))<0);

Now you asked to send 4 bytes. Now if only three were
sent ?

         while(Socket->SendBuf(&sz,sizeof(int))<0);

Ditto.

         while(sz>count)

Where is count initialized ? Why is this not a local variable
that you initialised  here ?
Are you using the same variable for receiving?

         {
                 if(Socket->SendBuf(fData,count)<0)
                         continue;

What was the value of count ? You should have put there sz.
And you assumed that all count bytes were sent.
Better:

    while ( sz )
         {
                int nsended = Socket->SendBuf(fData,sz);

                if ( nsended < 0 )
                  {
                  // decide what you do
                  }
                else
		{
                 sz-=nsended;
                 fData+=nsended;
                 }
         }

         while(Socket->SendBuf(fData,sz)<0);

Ditto.

}

Hans.