🚀 go-pugleaf

Remy Lebeau (TeamB) wrote:

> Also, your code is leaking the file stream on both sides.  You never close
> or free the streams.

There will be no leaking as deleting the stream is forbidden
if you use ->SendStream (stream ) for a TCustomWinSocket.

<from help>
bool __fastcall SendStream(Classes::TStream* AStream);

Note:	The Stream passed as a parameter to SendStream becomes
�owned� by the windows socket object.  The Windows socket
object frees the stream when it is finished with it.
Do not attempt to free the stream after it has been passed
as a parameter.
</from help>

Question: Would the stream only be deleted if SendStream succeeded ?
One would think yes. As otherwise a next call for the
rest of the data in the stream was impossible.


>             TFileStream* file = new TFileStream(OpenDialog1->FileName,
> fmOpenRead);
>             try
>             {
>                 if( !SendStream(ServerSocket1->Socket->Connections[0],
> file) )
>                     ShowMessage("Could not send file");
>                 }
>             }
>             __finally {
>                 delete file;
>             }

Is that tested code ? It conflicts with the help.

Hans.