🚀 go-pugleaf

"Drew" <aemsley@brightwell.org.uk> wrote in message
news:418ff4b9$1@newsgroups.borland.com...

> Over time, the mmory used by my application increases, increasing
> from about 9Mb at start-up to more than 100 Mb after a day or so.
> I am fairly certain that it is the Indy component that is causing the
problem

It would help if you could isolate where the supposed memory leak is
actually occuring.  Please try to find the actual line in your thread code
that is causing it.

>     if ((!GetConnected()) | (!CommOpen))

You have a typo in that line.  It should be using the "||" operator, not the
"|" operator.

>         bool IPConnected = true;  //Assume OK until we find otherwise

Rather than duplicating all of that connecting code, you could just call
Open().

>             tempBuff = new char[dataLength];
>
>             m_clientSocket->ReadBuffer(tempBuff, dataLength);
>             delete[] tempBuff;

You don't need to read the buffer.  Just clear it directly:

    m_clientSocket->InputBuffer->Clear();

>         m_clientSocket->OpenWriteBuffer();

You are not clearing the write buffer if an error occurs.

    try
    {
        m_clientSocket->WriteBuffer(buffer, ByteCount);
        m_clientSocket->CloseWriteBuffer();
    }
    catch(const Exception &)
    {
        m_clientSocket->CancelWriteBuffer(); // <-- add this
        Close();
        return eTCPwriteFailed;
    }


>                 tempBuff = new char[dataLength];
>
>                 m_clientSocket->ReadBuffer(tempBuff, dataLength);
>
>                 memcpy(&ReplyBuf[Index], tempBuff, dataLength);

Why are you using a temporary buffer?  You could just read into your target
buffer directly:

    m_clientSocket->ReadBuffer(&ReplyBuf[Index], dataLength);

>                 if (Index == ReplySize)

Where is ReplySize being set to?  Why are you not simply passing ReplySize
to ReadBuffer() directly and read the entire reply in a single operation?


Gambit