🚀 go-pugleaf

"Drew" <aemsley@brightwell.org.uk> wrote in message
news:411bdf12$1@newsgroups.borland.com...

>     RtrServer->Active = true;
>
>     RtrServer->CommandHandlersEnabled = true;

You should set up the command handlers before you activate the server, not
afterwards.

>     RtrServer->CommandHandlers->Add();
>     RtrServer->CommandHandlers->Items[0]->Command = readRtrParams;
>     RtrServer->CommandHandlers->Items[0]->OnCommand =
> RtrServerReadRtrParams;

You should use the return value of Add() instead of indexing the Items[]
collection over and over:

    TIdCommandHandler *Handler = RtrServer->CommandHandlers->Add();
    Handler->Command = readRtrParams;
    Handler->->OnCommand = RtrServerReadRtrParams;

> void __fastcall RTRSvrThread::RtrServerDisconnect(TIdPeerThread *AThread)
> {
>     Log(0, "Rtr Server disconnected");
> }

What exactly does Log() do?  Is its code thread-safe?

> The error log shows the following:
>
>     19:59:43.56: Rtr Server exception: Out of memory
>     19:59:43.56: Rtr server disconnected

That suggests that one of your command handlers is probably where the
exception is being thrown.  Can you please show the actual handler code?

>                                char* sendBuffer;
>
>                                sendBuffer = new char[sizeof(SiteData_t)];
>
>                                memcpy(sendBuffer, site,
sizeof(SiteData_t));
>
>                                Log(2, "Sending info buffer to DBM");
>                                DbmClient->WriteBuffer(sendBuffer,
> sizeof(SiteData_t));
>
>                                delete[] sendBuffer;

Why allocate a new buffer?  Just send the original data directly:

    DbmClient->WriteBuffer(site, sizeof(SiteData_t));


> On the client side, the error log shows:
>
>     19:59:43.56: Sending updateHilltopInfo message to DBM
>     19:59:43.56: Read of ACK from DBM failed
>     19:59:43.56: Exception gnerated = Connection Closed Gracefully.

That is to be expected since the server disconnected the client when the
exception occured.


Gambit