🚀 go-pugleaf

"Remy Lebeau \(TeamB\)" <no.spam@no.spam.com> wrote:
>
>"Peter" <piotrtrzeciak@yahoo.com> wrote in message 
>news:479f51f8$1@newsgroups.borland.com...
>
>> It appears that my code "crashes" when more then one connection is
>> being established from the client and the IOHandler's InputBuffer gets
>> stepped on.
>
>Then you are using it wrong.  Please show your actual code.
>
>> Is this buffer a separate one for each thread?
>
>For each connection, yes.
>
>
>Gambit 
>
>

Here is the code:

void __fastcall Tlens_srvc::iln_rcv_socketExecute(TIdContext *AContext)
{

	ImageData		*imageData;


	imageData = (ImageData *)malloc(sizeof(ImageData));

	imageData->INITC = RawToBytes("\x00\xA1", 2);
	imageData->DISPLAY = RawToBytes("\x00\xA9", 2);
	imageData->EVN_MESSAGE = RawToBytes("\x00\xA7", 2);

	AContext->Connection->IOHandler->ReadBytes(imageData->rcv_buffer, 20, false);

	imageData->requested_length = 2;
	imageData->msg = AContext->Connection->IOHandler->ReadSmallInt(true);

	if (imageData->msg > 0) {
		imageData->length = imageData->msg;
	}
	else {
		// error
		free(imageData);
		return;
	}
	imageData->requested_length = imageData->length - 2;

	AContext->Connection->IOHandler->ReadBytes(imageData->rcv_buffer, imageData->requested_length, false);

	// This return is here only for testing to exit without reading more data.
    //return;

	//
	// Figure out what command we are receiving
	//
	if ( (imageData->rcv_buffer[0] == imageData->INITC[0]) && (imageData->rcv_buffer[1] == imageData->INITC[1]) && (imageData->length > 4) ) {
		// INITC as OINT, no reads, just write a response to the socket
		processOint(AContext, imageData);
	}
	else {
		if ( (imageData->rcv_buffer[0] == imageData->INITC[0]) && (imageData->rcv_buffer[1] == imageData->INITC[1]) && (imageData->length <=4) ) {
			// INITC as INIT, no reads, just write a response to the socket
			processInit(AContext, imageData);
		}
		else {
			if ( (imageData->rcv_buffer[0] == imageData->DISPLAY[0]) && (imageData->rcv_buffer[1] == imageData->DISPLAY[1]) ) {
				// DISPLAY... this is when we get an image and read more data from the socket
				imageData->received_length = imageData->length;
				receiveImage(AContext, imageData);
			}
			else {
				if ( (imageData->rcv_buffer[0] == imageData->EVN_MESSAGE[0]) && (imageData->rcv_buffer[1] == imageData->EVN_MESSAGE[1]) ) {
					// EVN_MESSAGE. Error messages will come down from the host here, no more data from socket, just interpret message
					getEvnMessage(AContext, imageData);
				}
				else {
					// Other command... no processing

				}
			}
		}
	}

	//
	// Clean up
	//
	free(imageData);

}

Now, I put in a return statement in the middle, just to see if I can get more than one connection, but it still fails.
For any "command" other than DISPLAY, it works fine, because they only come as single connections. If I get a series of DISPLAY commands, the first one usually goes ok (depends on the timing), but the second client connection kills the service.
The only other thing I can think of, is that I'm adding the TIdTCPServer component to a wrong place (TService), and that's why it gets "clobbered".
I have to admit, it took me less to write this whole app from scratch the first time around, than to get Indy working :-( (but I think it's just a lack of docs and experience).
Thanks again.