🚀 go-pugleaf

"JLoz" <jfsierra@excite.com> wrote in message
news:46b10f2b$1@newsgroups.borland.com...

> Below is the stack trace you asked for.

That stack trace is showing a completely different error than the one you
have been describing.

> The "Cannot decode Response" error occurs after the fact
> as I have a try finally around this and it happens when I try
> to disconnect by using this code

Based on what the stack trace shows, what appears to be happening is that
the code is crashing while sending a login command to the server, so there
is likely unprocessed data from the server being left in the connection's
InputBuffer, such that when you call Disconnect() later, it sends a QUIT
command to the server and then ends up reading the unprocessed data from the
earlier command and fails.

>       if (!UpperCase(E.Message).Pos("RANGE CHECK ERROR")) {

That is not the best way to check for a specific exception type.  You should
be checking for the ERangeError class specifically instead, ie:

    catch (const Sysutils::ERangeError& E)
    {
        // why do you ignore this type of error?
    }
    catch (const Sysutils::Exception& E)
    {
        err = E.Message;
        Header.Set("Error", E.Message);
        Header.Set("Result", "0");
    }

Or:

    catch (const Sysutils::Exception& E)
    {
        if( dynamic_cast<const ERangeError*>(&E) == NULL )
        {
            err = E.Message;
            Header.Set("Error", E.Message);
            Header.Set("Result", "0");
        }
    }

Or:

    catch (const Sysutils::Exception& E)
    {
        if( !E.InheritsFrom(__classid(ERangeError)) )
        {
            err = E.Message;
            Header.Set("Error", E.Message);
            Header.Set("Result", "0");
        }
    }


>   if(err != "") throw Sysutils::Exception(AnsiString(err));

You should be re-throwing the original exception, not creating a new one.
You lose the original error information that way.

Try something more like this code instead:

    try
    {
        IdSMTP1->Connect();
        try
        {
            IdSMTP1->Send(IdMessage1);
        }
        __finally
        {
            IdMessage1->Clear();
            IdSMTP1->Disconnect();
        }
    }
    catch (const Sysutils::ERangeError & E)
    {
        // ignore ...
    }
    catch (const Sysutils::Exception& E)
    {
        Header.Set("Error", E.Message);
        Header.Set("Result", "0");
        throw;
    }

As for the actual cause of the original error, that is something that will
have to be looked into more deeply.  Since Indy 10 is currently undergoing a
major code review right now, the issue may have already been addressed for
the next release.


Gambit