🚀 go-pugleaf

Correction: >  Here is the relevant code from the server end:

void __fastcall TMyServerThread::ClientExecute(void)
{
   .................
while (!Terminated && ClientSocket->Connected)
{
        if (pStream->WaitForData(6000))
        {
           ReadPacket(pStream);
          TMemoryStream *Strm2 = new TMemoryStream;
          Strm2->Clear();
          FileName = "Thank You";
          SendTextMessage(Strm2, FileName);
          ClientSocket->SendBuf(Strm2->Memory, Strm2->Size);
        }
}
}


>  Here is the relevant code from the server end:

Maurice Anderson wrote:

>However, when trying to read data from TScoket to the ClientSocket, it does
>not work.  Here is the code I put in the ClientSocket->OnRead event:
>
>void __fastcall TForm1::ClientSocket1Read(TObject *Sender,
>      TCustomWinSocket *Socket)
>{
>
>   const int BytesToReceive = Socket->ReceiveLength();
>   if( BytesToReceive <= 0 )
>            return;
>
>  Memo1->Lines->Add("Server Transmitting: ");

That's on the main form?
I think you are supposed to Synchronize() with the main thread first.

>  TMemoryStream *ServerData = new TMemoryStream;
>  char *Buffer[256];

First, should be
  char Buffer[256];

Second, 256 is probably too small.
Should be larger than BytesToReceive.

	char * Buffer = new char[BytesToReceive];

>  Socket->ReceiveBuf(Buffer, BytesToReceive);

	delete[] Buffer;

>(2) Is ClientSocket->OnRead executed in a seperate thread?

Yes, usually.

>  (3) If not, is it wise to execute a client read in a seperate thread?

Yes.

>  (4) And if so, how do I accomplish that?

Use the OnRead event.

>I think you are supposed to Synchronize() with the main thread first.

Hello Bob, I updated my code with your suggestions but to no avail..... as
in:

while (!Terminated && ClientSocket->Connected)
{
        if (pStream->WaitForData(6000))
        {
           ReadPacket(pStream);
           Synchronize(DoStuffOnMainForm);

        }
}


void __fastcall TMyServerThread::DoStuffOnMainForm(void)
{
        AnsiString FileName = "Hello World";
        Strm2 = new TMemoryStream;
        Strm2->Clear();
        BinaryTransfer1->SendTextMessage(Strm2, FileName);
        ClientSocket->SendBuf(Strm2->Memory, Strm2->Size);
}

> Should be larger than BytesToReceive.
> char * Buffer = new char[BytesToReceive];

I also replaced char *Buffer[256] with char * Buffer = new
char[BytesToReceive];

> >(2) Is ClientSocket->OnRead executed in a seperate thread?
>
> Yes, usually.

Are you saying that there are times that ClientSocket->OnRead will execute
in the main thread?  If so what would cause it to alternate between
executing in a seperate thread and executing in the main thread?

> >  (4) And if so, how do I accomplish that?
>
> Use the OnRead event.

That's the event my code is executing in

Maurice Anderson wrote:

>while (!Terminated && ClientSocket->Connected)
>{
>        if (pStream->WaitForData(6000))
>        {
>           ReadPacket(pStream);
>           Synchronize(DoStuffOnMainForm);

I don't know why you would want to do that with DoStuffOnMainForm
since it doesn't seem to do stuff with the main form?

>void __fastcall TMyServerThread::DoStuffOnMainForm(void)
>{
>        AnsiString FileName = "Hello World";
>        Strm2 = new TMemoryStream;
>        Strm2->Clear();
>        BinaryTransfer1->SendTextMessage(Strm2, FileName);
>        ClientSocket->SendBuf(Strm2->Memory, Strm2->Size);
>}


>> >(2) Is ClientSocket->OnRead executed in a seperate thread?
>>
>> Yes, usually.
>
>Are you saying that there are times that ClientSocket->OnRead will execute
>in the main thread?  If so what would cause it to alternate between
>executing in a seperate thread and executing in the main thread?

It is just a function, after all.  Anyone can call it. Usually you
don't call it, and let it operate as intended.

"Maurice Anderson" <mauriceanderson@hotmail.com> wrote in message 
news:43b72c70$1@newsgroups.borland.com...

> However, when trying to read data from TScoket to
> the ClientSocket, it does not work.

Just saying that it does not work says nothing at all about the actual 
problem you are having.  Always provide specific details.

> Here is the code I put in the ClientSocket->OnRead event:

I assume, then, that you are using the TClientSocket in non-blocking mode? 
The code I gave you earlier was designed to be used in blocking mode, since 
you said that you were using TWinSocketStream.  The code has to be modified 
a bit to be usable with a non-blocking socket due to the more frequent 
occurances of incomplete data arriving in the socket at any given time.  The 
code you have so far is not enough to handle incoming packets in a reliable 
manner.  You must buffer all incoming data and then process it only when 
enough data is actually available.  You can go to http://www.deja.com and 
search the newsgroup archives.  Sample code has been posted many many times 
before.

> Here is the relevant code from the server end:

You are not doing any error cheecking in that code.  And I do not see you 
filling the TMemoryStream with any data before sending it.

> Is ClientSocket->OnRead executed in a seperate thread?

The OnRead event is triggered in the same thread that owns the 
TClientSocket.  TClientSocket is not a threaded component lik TServerSocket 
can be.  If you want to use TClientSocket with threads, then you have to 
manage the threading yourself.

> If not, is it wise to execute a client read in a seperate thread?

That will only work if you use the TClientSocket in blocking mode. 
TClientSocket is not thread-safe in non-blocking mode.

> These Misc Read/Write functions are defined in both the server and the
> client.  I use the same functions for consistencies sake:

The functions will work as long as the data is accurate, which is not always 
the case with the code you have shown so far.

Also, I will mention that your use of ShowMessage() is not thread-safe.  You 
cannot safely use ShowMessage() outside of the main thread.  If you want to 
display a message in a thread-safe manner, then use the Win32 API 
MessageBox() function.


Gambit 

"Bob Gonder" <notbg@notmindspring.invalid> wrote in message 
news:thjer1h3bk668mqjsldbil598c69mo46po@4ax.com...

>>  Memo1->Lines->Add("Server Transmitting: ");
>
> That's on the main form?
> I think you are supposed to Synchronize() with the main thread first.

According to the code, the access to the Memo is in an event that is 
triggered in the main thread to begin with.


Gambit 

"Maurice Anderson" <mauriceanderson@hotmail.com> wrote in message 
news:43b753c8$1@newsgroups.borland.com...

> Hello Bob, I updated my code with your suggestions but to no avail

Those changes were unnecessary.

> Are you saying that there are times that ClientSocket->OnRead
> will execute in the main thread?

If you are using TClientSocket in the main thread to begin with, then the 
OnRead event will always be triggered in the context of the main thread. 
TClientSocket is not a threaded component.

> If so what would cause it to alternate between executing in a
> seperate thread and executing in the main thread?

It wouldn't ever do that.


Gambit