🚀 go-pugleaf

"dzeidzei" <dzeidzei@suolakaivos.com> wrote in message
news:437b2354$1@newsgroups.borland.com...

> AnsiString * HttpsPostSMS(AnsiString *Url, AnsiString *Params)
> {
>   AnsiString *asRet = new AnsiString;

Why are you dynamically allocating AnsiString everywhere?  You should not
be.

> TIdHTTP *IdHTTP = new TIdHTTP(NULL);

You are not protecting that instantiation from unhandled exceptions.  If an
exception is thrown, you will have a lot of memory leaks in your code.

>   TIdConnectionInterceptOpenSSL *IdConnectionInterceptOpenSSL = new
TIdConnectionInterceptOpenSSL(NULL);

That component does not exist in either Indy 9 or 10.  You are using a very
old version of Indy, probably Indy 8.  Such versions are no longer
supported.  You should seriously consider upgrading to the latest
Development Snapshot of at least Indy 9 (though Indy 10 has more features).

> And when I try to call function above it'll trow 'Intercept value is not
valid'?

Since you are using a very outdated version of Indy, the only way to know
why that error occurs is for you to look at TIdHTTP's source code yourself.


Gambit

"Remy Lebeau \(TeamB\)" <no.spam@no.spam.com> wrote:

>> TIdHTTP *IdHTTP = new TIdHTTP(NULL);
>
>You are not protecting that instantiation from unhandled exceptions.  If an
>exception is thrown, you will have a lot of memory leaks in your code.

How to protect It from unhandled exeptions? I quess it's done automatically when i put TIdHTTP component to my form, but can't find out what is the proper way to instantiate it 'manually'.

- dzeidzei

"dzeidzei" <dzeidzei@suolakaivos.com> wrote in message
news:437c19ea$1@newsgroups.borland.com...

> How to protect It from unhandled exeptions?

By not allowing there to be any uncaught exceptions.  Use try...catch blocks
to catch them all.  Especially since you said you are putting the code into
a DLL.  A DLL is not allowed to let exceptions escape into the application.
That is very dangerous.  For example:

    AnsiString HttpsPostSMS(const AnsiString &Url, const AnsiString &Params)
    {
        AnsiString asRet;

        try
        {
            TIdHTTP *HTTP = new TIdHTTP(NULL);
            try
            {
                TIdConnectionInterceptOpenSSL *Intercept = new
TIdConnectionInterceptOpenSSL(IdHTTP);
                Intercept->SSLOptions->Method = sslvSSLv23;
                Intercept->SSLOptions->Mode = sslmClient;
                Intercept->SSLOptions->VerifyDepth = 0;

                HTTP->Intercept = Intercept;
                HTTP->InterceptEnabled = true;

                TStringStream *tsParams = new TStringStream(Params);
                try
                {
                    HTTP->Request->ContentType =
"application/x-www-form-urlencoded";
                    asRet = HTTP->Post(Url, tsParams);
                }
                __finally
                {
                    delete tsParams;
                }
            }
            __finally
            {
                delete HTTP;
            }
        }
        catch(const Exception &e)
        {
            asRet = "Error: " + e.Message;
        }

        return asRet;
    }


You can then use the std::auto_ptr class to clean up the code further:

    #include <memory>

    AnsiString HttpsPostSMS(const AnsiString &Url, const AnsiString &Params)
    {
        try
        {
            std::auto_ptr<TIdHTTP> HTTP(new TIdHTTP(NULL));

            TIdConnectionInterceptOpenSSL *Intercept = new
TIdConnectionInterceptOpenSSL(HTTP.get());
            Intercept->SSLOptions->Method = sslvSSLv23;
            Intercept->SSLOptions->Mode = sslmClient;
            Intercept->SSLOptions->VerifyDepth = 0;

            HTTP->Intercept = Intercept;
            HTTP->InterceptEnabled = true;

            std::auto_ptr<TStringStream> tsParams(new
TStringStream(Params));

            HTTP->Request->ContentType =
"application/x-www-form-urlencoded";
            return HTTP->Post(Url, tsParams);
        }
        catch(const Exception &e)
        {
            return "Error: " + e.Message;
        }
    }


Gambit

Thanks! 

Now I've upgraded to Indy 90017 and my function looks as follows:

AnsiString HttpsPostSMS(const AnsiString &Url, const AnsiString &Params)
{
  AnsiString asResponse;
  try
  {
		std::auto_ptr<TIdHTTP> IdHTTP(new TIdHTTP(NULL));
    TIdConnectionIntercept *IdConnectionIntercept = new TIdConnectionIntercept(IdHTTP.get());
		TIdSSLIOHandlerSocket *IdSSLIOHandlerSocket = new TIdSSLIOHandlerSocket(IdHTTP.get()) ;
    TStringStream * tsParams = new TStringStream(Params);

    try
    {
      IdSSLIOHandlerSocket->SSLOptions->Method = sslvSSLv23;
  		IdSSLIOHandlerSocket->SSLOptions->Mode = sslmClient;
  		IdSSLIOHandlerSocket->SSLOptions->VerifyDepth = 0;
      IdHTTP->Request->ContentType = "application/x-www-form-urlencoded";
    	IdHTTP->Intercept = IdConnectionIntercept;
    	IdHTTP->IOHandler = IdSSLIOHandlerSocket;
  	asResponse = IdHTTP->Post(Url, tsParams);

    	return (asResponse.Trim());
    }
    __finally
    {
    delete tsParams;
      delete IdConnectionIntercept;
      delete IdSSLIOHandlerSocket;
    }
  }
  catch(const Exception &e)
  {
   	return ("Error: " + e.Message);
  }
}

Now I've upgraded to Indy 90017 and my function looks as follows:

AnsiString HttpsPostSMS(const AnsiString &Url, const AnsiString &Params)
{
  AnsiString asResponse;
  try
  {
    std::auto_ptr<TIdHTTP> IdHTTP(new TIdHTTP(NULL));
    TIdConnectionIntercept *IdConnectionIntercept = new TIdConnectionIntercept(IdHTTP.get());
    TIdSSLIOHandlerSocket *IdSSLIOHandlerSocket = new TIdSSLIOHandlerSocket(IdHTTP.get()) ;
    TStringStream * tsParams = new TStringStream(Params);

    try
    {
      IdSSLIOHandlerSocket->SSLOptions->Method = sslvSSLv23;
      IdSSLIOHandlerSocket->SSLOptions->Mode = sslmClient;
      IdSSLIOHandlerSocket->SSLOptions->VerifyDepth = 0;
      IdHTTP->Request->ContentType = "application/x-www-form-urlencoded";
      IdHTTP->Intercept = IdConnectionIntercept;
      IdHTTP->IOHandler = IdSSLIOHandlerSocket;
      asResponse = IdHTTP->Post(Url, tsParams);

      return (asResponse.Trim());
    }
    __finally
    {
      delete tsParams;
      delete IdConnectionIntercept;
      delete IdSSLIOHandlerSocket;
    }
  }
  catch(const Exception &e)
  {
   	return ("Error: " + e.Message);
  }
}

And when I tried to call it, I'll get 'IOHandler value is not valid' error. It seems that problem persists...

-dzeidzei

Thanks!
But when I paste Your code to my function, I still get 'IOHandler value is not valid' when calling??? 

"Remy Lebeau \(TeamB\)" <no.spam@no.spam.com> wrote:
>
>"dzeidzei" <dzeidzei@suolakaivos.com> wrote in message
>news:437d851c$1@newsgroups.borland.com...
>
>> Now I've upgraded to Indy 90017
>
>The latest snapshot build is 9.0.50.
>
>> and my function looks as follows:
>
>Get rid of the Intercept.  It is no longer needed.  The IOHandler will
>handle everything.
>
>>       delete IdConnectionIntercept;
>>       delete IdSSLIOHandlerSocket;
>
>Get rid of those.  They are not needed since the TIdHTTP is the owner for
>them.
>
>The code can be as follows:
>
>    #include <memory>
>
>    AnsiString HttpsPostSMS(const AnsiString &Url, const AnsiString &Params)
>    {
>        try
>        {
>            std::auto_ptr<TIdHTTP> HTTP(new TIdHTTP(NULL));
>            TIdSSLIOHandlerSocket *SSL = new
>TIdSSLIOHandlerSocket(HTTP.get()) ;
>
>            SSL->SSLOptions->Method = sslvSSLv23;
>            SSL->SSLOptions->Mode = sslmClient;
>            SSL->SSLOptions->VerifyDepth = 0;
>            HTTP->IOHandler = SSL;
>
>            std::auto_ptr<TStringStream> tsParams(new
>TStringStream(Params));
>            HTTP->Request->ContentType =
>"application/x-www-form-urlencoded";
>
>            return HTTP->Post(Url, tsParams.get()).Trim();
>        }
>        catch(const Exception &e)
>        {
>            return ("Error: " + e.Message);
>        }
>    }
>
>
>Gambit
>
>

This seems quite interesting. And when I put those components to a form it's working just fine...

"Remy Lebeau \(TeamB\)" <no.spam@no.spam.com> wrote:
>
>"dzeidzei" <dzeidzei@suolakaivos.com> wrote in message
>news:437d85b3$1@newsgroups.borland.com...
>
>> my function looks as follows:
><snip>
>> And when I tried to call it, I'll get 'IOHandler value is
>> not valid' error. It seems that problem persists...
>
>Given the code you have shown, that error is not possible.  The *only*
>condition that produces that error is when the IOHandler property is not
>pointing to a TIdSSLIOHandlerSocket when requesting an HTTPS Url.  That is
>clearly not the case in your code.
>
>
>Gambit
>
>

"dzeidzei" <dzeidzei@suolakaivos.com> wrote in message
news:437d851c$1@newsgroups.borland.com...

> Now I've upgraded to Indy 90017

The latest snapshot build is 9.0.50.

> and my function looks as follows:

Get rid of the Intercept.  It is no longer needed.  The IOHandler will
handle everything.

>       delete IdConnectionIntercept;
>       delete IdSSLIOHandlerSocket;

Get rid of those.  They are not needed since the TIdHTTP is the owner for
them.

The code can be as follows:

    #include <memory>

    AnsiString HttpsPostSMS(const AnsiString &Url, const AnsiString &Params)
    {
        try
        {
            std::auto_ptr<TIdHTTP> HTTP(new TIdHTTP(NULL));
            TIdSSLIOHandlerSocket *SSL = new
TIdSSLIOHandlerSocket(HTTP.get()) ;

            SSL->SSLOptions->Method = sslvSSLv23;
            SSL->SSLOptions->Mode = sslmClient;
            SSL->SSLOptions->VerifyDepth = 0;
            HTTP->IOHandler = SSL;

            std::auto_ptr<TStringStream> tsParams(new
TStringStream(Params));
            HTTP->Request->ContentType =
"application/x-www-form-urlencoded";

            return HTTP->Post(Url, tsParams.get()).Trim();
        }
        catch(const Exception &e)
        {
            return ("Error: " + e.Message);
        }
    }


Gambit

"dzeidzei" <dzeidzei@suolakaivos.com> wrote in message
news:437d85b3$1@newsgroups.borland.com...

> my function looks as follows:
<snip>
> And when I tried to call it, I'll get 'IOHandler value is
> not valid' error. It seems that problem persists...

Given the code you have shown, that error is not possible.  The *only*
condition that produces that error is when the IOHandler property is not
pointing to a TIdSSLIOHandlerSocket when requesting an HTTPS Url.  That is
clearly not the case in your code.


Gambit