🚀 go-pugleaf

"Paw Suddergaard" <paw@easyflex.dk> wrote in message
news:428c63af@newsgroups.borland.com...

> I can send the email, and the attachments. But the html come out as
code...

That is because you are not setting up the message properly at all.

>     TIdText(IdMessage->MessageParts, TempList); //just the same...
>     TIdText(IdMessage->MessageParts, TempList); //html

That shouldn't even compile.  You need to call TIdText's constructor via the
'new' operator.

Also, you never set up the ContentType for the TIdText instances at all.

Also, you have memory leaks in your use of temporary TStringList that you
never free properly.

Use this code instead:

    try
    {
        IdMessage->From->Address = FromEmail;
        IdMessage->From->Name = FromName;
        IdMessage->ReplyTo->EMailAddresses = FromEmail;
        IdMessage->Subject = eSubject->Text;
        IdMessage->Recipients->EMailAddresses = ToEMail;
        TIdText *TempText = new TIdText(IdMessage->MessageParts, NULL);
        TempText->ContentType = "text/plain";
        // fill in TempText->Body with plain text...
        TempText = new TIdText(IdMessage->MessageParts, NULL);
        TempText->ContentType = "text/html";
        // fill in TempText->Body with html...
        TStringList *TempList = FindImagesInHTML(Filename);
        try
        {
            for(int i = 0; i < TempList->Count; ++i)
            {
                TIdAttachment *IImagePart = new
TIdAttachment(IdMessage->MessageParts, TempList->Strings[i]);
                IImagePart->ContentType = "image/jpg";
                IImagePart->ContentID =
ExtractFileName(TempList->Strings[i]);
            }
        }
        __finally {
            delete TempList;
        }
        IdSMTP->Host = frmToolL->Host;
        IdSMTP->Username = frmToolL->UserId;
        IdSMTP->Connect();
        try {
            IdSMTP->Send(IdMessage);
        }
        __finally {
            IdSMTP->Disconnect();
        }
    }
    catch(const Exception &) {
        //...
    }


Gambit

Hi again!

Thankyou very much! That helped alot.

But i still have some problems...

My HTML Code gets messed up!

Here' an example:

Original:
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=windows-1252">
<META NAME="Generator" CONTENT="Internet Assistant for Word Version 3.0">
</HEAD>
<BODY>

When recieving the email:
<HTML>
<HEAD>
<META HTTP-EQUIV=3D"Content-Type" CONTENT=3D"text/html; charset=3Dwindow=
s-1252">
<META NAME=3D"Generator" CONTENT=3D"Internet Assistant for Word Version =
3.0">
</HEAD>
<BODY>

Where does the 3D come from and sometimes there are an = sign?

Any idea?

And last but not least...

2 questions:

1. Is it really nessecary to delete the templist? Doesn't the VCL do 
this for me?

2. catch(const Exception &) ?? Why can't i use catch(...)???

Thanks!!!!

"Paw Suddergaard" <paw@easyflex.dk> wrote in message
news:428c88d1$1@newsgroups.borland.com...

> When recieving the email:
<snip>
> Where does the 3D come from and sometimes there are an = sign?

The text is being encoded using the Quoted-Printable algorithm for
transmission.  That is perfectly normal.  The 'Content-Transfer-Encoding'
header for the text should be getting set to 'Quoted-Printable', which will
tell the receiver that it needs to decode the text before displaying/saving
it.

> 1. Is it really nessecary to delete the templist?

Yes, otherwise the memory is leaked.  Unless your FindImagesInHTML()
function is actually returning a TStringList that is owned elsewhere in code
that you did not show which will free the TStringList later on.

> Doesn't the VCL do this for me?

No, it does not.

> 2. catch(const Exception &) ?? Why can't i use catch(...)???

99.9999% of the possible exceptions that can be thrown in the code you
showed will be based on the Exception class.  The only one that will not
will be is if the 'new' operator fails, in which case a std::bad_alloc
exception will be thrown instead.  However, I'm not so sure about even that,
since 'new' is allocating VCL objects, so Borland's VCL memory manager is
being invoked instead of the C runtime memory manager instead, so the
resulting exception will probably be VCL-based as well.

Also, you did not specify which version of BCB you are actually using, but
BCB6 changed how '...' handles VCL exceptions, so it is good practive to no
longer use '...' to handle VCL exceptions.  They should be caught
explicitally.


Gambit