🚀 go-pugleaf

Hi Remy,
Thanks much for the hint. From the beginning, i assumed that the code
fails because it tries to grab links from not-yet-fully-loaded
iframes. Totally agree with you.

As a Java programmer, i am getting familiar with the Borland C
library. Could you please confirm that the following code snippet will
do busy-waiting till the iframe has been fully loaded:
while(!(bp->ReadyState == Shdocvw_tlb::READYSTATE_COMPLETE)) {
	// Busy-waiting
}
// NOW the iframe and webpage are supposed to be fully loaded

Following is the full picture of our code. Regrettably, it's still
stuck with the CNN.COM, we never can grab any link from the iframes.
********************************************************************************************************
// BrowserDocumentComplete: This caller will call service getFrame and
getLinks to extract all the links inside the webpage
void __fastcall TMainForm::BrowserDocumentComplete(TObject *Sender,
      LPDISPATCH pDisp, Variant *URL)
{
  // Van's note:  Inject this bug intentionally. The app fails even
when user click the Web Btn. Why?
  // Why this function is called even when user clicks the Web Btn,
hasn't browse any webpage yet
  /*
  IHTMLDocument2 *dummmy_p1=NULL;
  assert(dummmy_p1!=NULL);
  */

  BrowserReady=true;
  WWWIsLoading=false;
  MainForm->WWWCurrentLink=0;
  WWWResetScanning();
  //
  if (WWWNumLinks>0) {
    FocusLink(Browser, 0);
  }

  WWWFrameCount=FrameCount(Browser);
  WWWCurrentFrame=0;

  if (WWWFrameCount==0) {
      assert(WWWCurrentLink<WWWNumLinks);
      assert(WWWCurrentLink>=0);
      WWWCurrentLinkp= GetLink(Browser, WWWCurrentLink);
  } else {
    // ToDo: Check if all frames are link-less.
    IHTMLDocument2 *thisframe=NULL;
    WWWCurrentFrame=WWWFrameCount-1;    // Van's note: Extract the
links from the top-most frame
    //
    thisframe=GetFrame(Browser, WWWCurrentFrame);

    //
    if(thisframe!=NULL) {
        assert(thisframe!=NULL);
        long linksthisframe=NumLinks(thisframe);

        if (WWWLinkSelected) {
                //assert(WWWCurrentLink<linksthisframe); // failed
with cnn.com
                if (WWWCurrentLink<linksthisframe) {
                        assert(WWWCurrentLink>=0);
                        WWWCurrentLinkp=GetLink(thisframe,
WWWCurrentLink);
                        thisframe->Release();
                } else {
                        // Van's note: Do nothing for now
                }
        }
    } else {
        // Do nothing if thisframe==NULL for now.
        // For debugging purpose. MUST NEVER BRANCH THIS WAY
        IHTMLDocument2 *dummmy_p4=NULL;
        assert(dummmy_p4!=NULL);
    }
  }     // End of if (WWWFrameCount==0)

  WWWLinkSelected=true;
  if (WWWCurrentLinkp!=NULL){
    getlinkborder(WWWCurrentLinkp, WWWCurrentLinkStyleWas);
    setlinkborder(WWWCurrentLinkp, "1.0mm solid red");
  } else {
     // accept that we do nothing if WWWCurrentLinkp == NULL
     // For debugging purpose. MUST NEVER BRANCH THIS WAY
     IHTMLDocument2 *dummmy_p5=NULL;
     assert(dummmy_p5!=NULL);
  }
  if (WWWScanMode == WWWScanModeStr[0]) MainForm->WWWLinkScanTimer-
>Enabled=false;
//--------------------

  // ToDo - scanning mellem frames
  setfields();

}


// Following are the callees
int FrameCount(TCppWebBrowser *bp) {
  IHTMLDocument2 *HTMLDoc = NULL;

  long collSize=0;

  // replaced by this standard code???
  if( (bp->ReadyState == Shdocvw_tlb::READYSTATE_COMPLETE) && (bp-
>Document) &&
        SUCCEEDED(bp->Document->QueryInterface(IID_IHTMLDocument2,
        (LPVOID*)&HTMLDoc)) )
  {
    IHTMLFramesCollection2 *pColl = NULL;

    if(SUCCEEDED(HTMLDoc->get_frames(&pColl))) {
      pColl->get_length(&collSize);
      pColl->Release();
    }
  }
  if (HTMLDoc) HTMLDoc->Release();
  return collSize;
}

// van's note: Failed when deal with IFRAMEs
IHTMLDocument2* GetFrame(TCppWebBrowser *bp, int idx) {
  IHTMLDocument2 *HTMLDoc = NULL, *res=NULL;

  long collSize=0;

  // Busy waiting till the iframe has been fully loaded
  while (!CompletedLoading(bp)) {

  };

  if( (bp->ReadyState == Shdocvw_tlb::READYSTATE_COMPLETE) && (bp-
>Document) &&
        SUCCEEDED(bp->Document->QueryInterface(IID_IHTMLDocument2,
        (LPVOID*)&HTMLDoc)) )
  {
    IHTMLFramesCollection2 *pColl = NULL;

    if(SUCCEEDED(HTMLDoc->get_frames(&pColl))) {
      pColl->get_length(&collSize);

      assert(collSize>0);

      if (collSize>idx) {
        VARIANT one;
        VariantInit(&one);      // v's
        one.vt = VT_UINT;
        one.lVal = idx;

        VARIANT out;
        VariantInit(&out);      // v's
        pColl->item(&one,&out);
        //
        IHTMLWindow2 *win=NULL;
        if (SUCCEEDED(out.pdispVal->QueryInterface( IID_IHTMLWindow2,
(LPVOID*)&win ))) {
          // van's note
          assert(win);   // passed with CNN.com
          // van's note: Can not pass with CNN.com. Why we can not
assign win->get_document(&res)????
          // van's note: For some reasson, this assignment is failed
with some webpage
          if (!SUCCEEDED(win->get_document(&res))) {
            res=NULL;
          }
          win->Release();
        } else {
          res=NULL;
        } // end if (SUCCEEDED(out.pdispVal->....

	VariantClear(&one);       // v's
	VariantClear(&out);       // v's
      } // end if (collSize>idx)

      pColl->Release();
    } // end if(SUCCEEDED(HTMLDoc->get...
  } // end if( (bp->ReadyState == .....

  if (HTMLDoc) HTMLDoc->Release();
  // van's note: Bug 2: This assertion failed with CNN.COM. The
function return null.
  // For debugging purpose. MUST NEVER FAILS. REGRETABBLY, STILL FAILS
  assert(res);
  return res;
}
//
bool CompletedLoading(TCppWebBrowser *bp) {
  return bp->ReadyState==Shdocvw_tlb::READYSTATE_COMPLETE;
}
********************************************************************************************************