🚀 go-pugleaf

"Boba" <Boba@somewhere.world> wrote in message
news:459a89d6@newsgroups.borland.com...

> ...hmmm... both gave the same result. i wish i knew why.

Considering that none of your code is doing any error handling, you
did not specify the contents of the values you are passing, and you
did not specify on which line the failure is actually occuring, there
is no way to diagnose your problem.  You need to provide more
information.

> here's a sample call: DownloadFile("download.microsoft.com",
>
"/download/6/a/f/6af940c1-2774-4ebb-8546-2c83068af231/Windows2000-KB92
6247-x86-E
> NU.EXE");

Ok so far.  Though again, there is no reason to separate the server
from the path like that.  You should be passing it as a single
complete URL string, ie:


DownloadFile("http://download.microsoft.com/download/6/a/f/6af940c1-27
74-4ebb-8546-2c83068af231/Windows2000-KB926247-x86-ENU.EXE");

> > I suggest you use HttpQueryInfo() to retreive the size of the data
> > before then entering the loop.
>
> InternetQueryDataAvailable() is supposed to do that.

Your looping code is wrong anyway.  You are not using the value that
InternetQueryDataAvailable() returns.  You must read everything that
InternetQueryDataAvailable() reports, or else it cannot report more
data later.  This is clearly stated in the documentation.  You need to
change your loop to something more like the following instead:

    BYTE Buffer[1024];
    DWORD dwDataSize, dwBytesToRead, dwBytesRead, dwBytesDownloaded;

    dwBytesDownloaded = 0;

    while( InternetQueryDataAvailable(hHttpRequest, &dwDataSize, 0,
0) )
    {
        if( dwDataSize == 0 )
            break;

        do
        {
            dwNumToRead = min(dwDataSize, sizeof(Buffer));

            if( !InternetReadFile(hHttpRequest, Buffer, dwBytesToRead,
&dwBytesRead) )
                break;

            // write the data...
            dwDataSize -= dwBytesRead;
            dwBytesDownloaded += dwBytesRead;
        }
        while( dwDataSize != 0 );
     }


However, I strongly suggest you use HttpQueryInfo() instead of
InternetQueryDataAvailable().  Then you need only 1 loop instead of 2,
since the download already knows the full size of the data ahead of
time, ie:

    BYTE Buffer[1024];
    DWORD dwDataSize, dwBytesToRead, dwBytesRead, dwBytesDownloaded,
dwIndex = 0;
    DWORD dwLen = sizeof(dwDataSize);

    dwBytesDownloaded = 0;

    if( HttpQueryInfo(hHttpRequest, HTTP_QUERY_CONTENT_LENGTH |
HTTP_QUERY_FLAG_NUMBER, &dwDataSize, &dwLen, &dwIndex) )
    {
        while( dwDataSize != 0 )
        {
            dwNumToRead = min(dwDataSize, sizeof(Buffer));

            if( !InternetReadFile(hHttpRequest, Buffer, dwBytesToRead,
&dwBytesRead) )
                break;

            // write the data...
            dwDataSize -= dwBytesRead;
            dwBytesDownloaded += dwBytesRead;
        }
    }


Gambit