🚀 go-pugleaf

"Martin C" <martinc@aol.com> wrote in message
news:4042b3bc@newsgroups.borland.com...

>                  sFullPath = szPath;

What is szPath declared as an where does it get its value?  Neither is
present in the code you have shown.

>                  dwAttributes = GetFileAttributes(sFullPath.c_str());

You are not checking to see if GetFileAttributes() returns an error.  In
fact, you don't need to call GetFileAttributes() at all, the file's
attributes are already contained in the WIN32_FIND_DATA structure.

>                       DeleteAllFilesFolders(sFullPath.c_str(),
MaskToFind);

You are not returning any return value from DeleteAllFilesFolders() to make
sure that it is even safe to call RemoveDirectory().

>                       RemoveDirectory(sFullPath.c_str());

You are not checking to see if RemoveDirectory() returns an error.

>                        if(MaskToFind == "*.*")

You don't need to test for that individually, MatchesMask() will handle
"*.*" as well.

>                                 DeleteFile(sFullPath);

You are not checking to see if DeleteFile() returns an error.

Try this code instead:

    bool __fastcall TForm1::DeleteAllFilesFolders(const AnsiString &Folder,
const AnsiString &MaskToFind)
    {
        WIN32_FIND_DATA wfd;
        HANDLE hFind;
        String sFullPath, sFindFilter, sCurrentFolder;
        bool Result = true;

        sCurrentFolder = IncludeTrailingBackslash(Folder);
        sFindFilter = sCurrentFolder + "*.*";

        hFind = FindFirstFile(sFindFilter.c_str(), &wfd);
        if( hFind != INVALID_HANDLE_VALUE )
        {
            do
            {
                if( (_tcscmp(wfd.cFileName, _T(".")) == 0) ||
(_tcscmp(wfd.cFileName, _T("..")) == 0) )
                    continue;

                sFullPath = sCurrentFolder + String(wfd.cFileName);

                if( wfd.dwFileAttributes & FILE_ATTRIBUTE_READONLY )
                {
                    Result = SetFileAttributes(sFullPath.c_str(),
wfd.dwFileAttributes & ~FILE_ATTRIBUTE_READONLY);
                    if( !Result )
                        break;
                }

                if( wfd.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY )
                {
                    Result = DeleteAllFilesFolders(sFullPath, MaskToFind);
                    if( Result )
                        Result = RemoveDirectory(sFullPath.c_str());
                }
                else
                {
                    if( MatchesMask(wfd.cFileName, MaskToFind) )
                        Result = DeleteFile(sFullPath);
                }
            }
            while( (Result) && (FindNextFile(hFind, &wfd)) );
            FindClose(hFind);
        }

        return Result;
    }


Gambit