🚀 go-pugleaf

"Martin C" <martinc@aol.com> wrote in message
news:4042c611@newsgroups.borland.com...

> As long as I use DeleteFile function there is no problem at all, all
> files are deleted fast. But when I add some functions to securely
> overwrite and delete files so it can't be recovered, I find that the
> DeleteAllFilesFolders function delete some files and leave other,
> without any logical reason why those files where left

My guess would be that your secure deletion functions are not closing all
file handles correctly, and/or not allowing files to be fully closed and
flushed to disk adequately before then trying to delete them, such that
DeleteFile() is then failing afterwards.

>   hFind = FindFirstFile((LPCTSTR)FileInformation.c_str(), &FindFileData);

Why are you calling FindFirstFile() again?  You already have all of the
relavant file information available for the given file before you call
SecureDeleteFiles() (btw, why is the function name plural if you are only
deleting a single file?).

>      SecureDelete1(FileName.c_str(), FindFileData.nFileSizeHigh,
> FindFileData.nFileSizeLow);

Where is FileName declared and where does it get its value from?  Again, you
are showing bits of pieces of incomplete code that suggest you are not
copy/pasting your actual code as-is directly from your project.  If you are,
in fact, copy/pasting your code directly, then you have a bug in your code
in that you are not using the function's FileInformation parameter when
calling SecureDelete1().

Since you are calling SecureDeleteFiles() for the sole purpose of calling
FindFirstFile() to obtain data you already have anyway, you can get rid of
SecureDeleteFiles() altogether and call SecureDelete1() from
DeleteAllFilesFolders() directly:

    if( MatchesMask(wfd.cFileName, MaskToFind) )
    {
        if( SecureDeleteOn )
            Result = ::DeleteFile(sFullPath.c_str());
        else
            Result = SecureDelete1(sFullPath.c_str(), wfd.nFileSizeHigh,
wfd.nFileSizeLow);
    }

BTW, shouldn't that if() statement be the other way around?  Naming a
variable 'SecureDeleteOn' suggests that you want secure deleting when the
value is 'true', but you did not actually code it that way.

>   SetFilePointer( hFile, FileLengthLo, (PLONG)&FileLengthHi, FILE_BEGIN);

If all you are trying to do is seek to the end of the file, you could use
FILE_END instead:

    SetFilePointer( hFile, -1, NULL, FILE_END );

> CloseHandle( hFile );

Try calling FlushFileBuffers() before closing the file handle.


Gambit