🚀 go-pugleaf

"Remy Lebeau (TeamB)" wrote:

>HRESULT TIContextMenuImpl::InvokeCommand(LPCMINVOKECOMMANDINFO lpici)
>{
>    //...
>    TMyForm *form = new TMyForm(NULL);
>    try {
>        form->ShowModal();
>    }
>    __finally {
>        delete form;
>    }
>    //...
>}
>
>Alternatively, use an std::auto_ptr instead of a try...finally:
>
>#include <memory>
>
>HRESULT TIContextMenuImpl::InvokeCommand(LPCMINVOKECOMMANDINFO lpici)
>{
>    //...
>    std::auto_ptr<TMyForm> form(new TMyForm(NULL));
>    form->ShowModal();
>    //...
>}

A context menu handler is an in-process server that runs in the Explorer
address space. So you should catch exceptions and return an HRESULT
value. Otherwise, Explorer may crash if an exception is thrown.

HRESULT TIContextMenuImpl::InvokeCommand(LPCMINVOKECOMMANDINFO lpici)
{
    //...
    TMyForm* form = NULL;
    try {
        form = new TMyForm(NULL);
        form->ShowModal();
    }
    catch(...) {
        delete form;
        return E_FAIL;
    }
    delete form;
    //..
    return S_OK;
}

or

#include <memory>

HRESULT TIContextMenuImpl::InvokeCommand(LPCMINVOKECOMMANDINFO lpici)
{
    //...
    try {
        const std::auto_ptr<TMyForm> form(new TMyForm(NULL));
        form->ShowModal();
    }
    catch(...) {
        return E_FAIL;
    }
    //..
    return S_OK;
}

Hernan Tornielli