🚀 go-pugleaf

"Dennis Jones" <djones@nospam.com> wrote in message
news:3f90be9d@newsgroups.borland.com...

> My latest version of code that is SUPPOSED to work follows.
> Does anyone know why this does not work?  Is there a bug in
> Windows that prevents this code form functioning properly?

I tried your code as-is, under Win98, Win2K, and XP.  They all worked fine
for me.  I had no troubles initializing the dialog using UNC paths when they
are converted to PIDLs first, other then a few secnods delay while the OS
resolved the PIDLs for use.

With that in mind, I would like to make some extra comments:

1) you have several variables that are not initialized before use,
particularly your buffers.  You should always iniitialize buffers and
structures to zeros initially.  In some cases, the Win32 API actually
*requires* you to do so.  When you do not initialize buffers, the buffers
will be filled with random memory, which could cause members to contain
values that will cause API operations to fail.

2) for character buffers, you should allocate (MAX_PATH+1) characters, in
case you happen to try working with paths that are exactly MAX_PATH
characters in size, so that you always have extra room for a
null-terminator.

3) you should never use strcpy() because it does not protect against buffer
overflows.  Use either strncpy() or StrLCopy() instead.

4) to cut down on some code complexity, you can use CoTaskMemFree() instead
of using SHGetMalloc() and IMalloc::Free() manually.  CoTaskMemFree() uses
IMalloc internally.


Gambit