🚀 go-pugleaf

Martin C wrote:

>HWND __fastcall TForm1::SearchProgramHandl(AnsiString ExeNameToHide)
>{
> HANDLE SysResHandl, RProgHandl;
> PROCESSENTRY32 Proc;
> String SRExename;
>
> RProgHandl=0;
>
> SysResHandl = CreateToolhelp32Snapshot(TH32CS_SNAPPROCESS, 0);
>
>  if (SysResHandl == INVALID_HANDLE_VALUE)
>  {  return 0; } else { }
>
>  try
>  {
>    Proc.dwSize = sizeof(Proc);
>    if(Process32First(SysResHandl, &Proc))
>    {
>      do
>      {
Should check that dwSize includes szExeFile ( > 9*4 )

>            SRExename = ExtractFileName(Proc.szExeFile); //Get the First Exe

I don't do VCL.  I'll assume you've checked the result of the Extract.
Wonder why you didn't Extract the NameToHide too.

>             if(UpperCase(Trim(ExeNameToHide))==UpperCase(Trim(SRExename)) )

That's a boat load of copying, and then you throw it all way, very
inefficient.

>              {  RProgHandl = OpenProcess(PROCESS_ALL_ACCESS, true,
>Proc.th32ProcessID); // Get Exe Handle
	What happens if this fails? Need error handling here.
	Also, shouldn't you break the loop when you've found it?
>              }
>              else
>              {  RProgHandl=0;
	Why are you resetting this?
>              }

I think you're supposed to reset dwSize here, as it can change.

>      }while(Process32Next(SysResHandl, &Proc));
>    }
>    else
>    { RProgHandl=0;
	And again? You cleared this at the top.
>    }
>  }
>
>  return RProgHandl;

Ok, now you have the ProcessHandle for the app in question.
But, don't you want a WindowHandle to pass to ShowWindow()?