🚀 go-pugleaf

"Victor G. Baron" <vgbaron@hotmail.com> wrote in message
news:525fovoj0ltdsbhpo7vo2tsen3nrsa2g1l@4ax.com...

> In the header I have this:

I didn't need the service code, just the thread code related to the
TStringList and its usage.

> __fastcall TConvThread::TConvThread(bool CreateSuspended)

What are you setting CreateSuspended to?  Under BCB5, if you set
CreateSuspended to false, the underlying thread object can begin running
before the constructor has had a chance to execute to initialize the
thread's members.  If you are not already doing so, you should always create
a thread suspended and then manually Resume() it after the constructor is
finished doing what it needs to do.

>    while (!Terminated)

How many times are you actually processing the file?  If once, then you need
to get rid of the while() loop altogether, otherwise you will process the
same file over and over and over.  Is that what you really want?

>    // and clean up the string list
>    delete inputfile;

Are you freeing the TStringList *inside* the while() loop?  If so, then the
code will crash on the second iteration of the list as the pointer will
still contain a memory address (since you did not set the pointer to NULL
after the deletion) but the actual memory being pointed to will no longer be
valid.  That's probably your actual crash right there.

To ensure that the TStringList is always valid for each iteration of the
loop, you need to free it outside the loop, not inside of it.  Better would
be to move the instantiation back into the thread's constructor rather than
inside Execute() (and of course adding a destructor to free it).

>     Sleep(6000);   // cycle every ten minutes

That call will re-iterate the loop every 6 seconds, not every 10 minutes.
10 minutes would be (1000*60*10), or 600,000.


Gambit