🚀 go-pugleaf

Something that bothers me about that code is what is it going
to do if the user has his finger on the shift key.  Unfortunately
I can't think of an easy way around that and holding your finger
on that key is not normal user behavior.

This has now gotten into personal preferences so I'll show mine
(feel free to criticize or make fun of them - I've been married for
years so am used to it <g>).

Try this instead:

  --------------
  void SendCString(const char* s)
    {
    const char CSpecialChar[] = "!@#$%^&*()_+{}|:<>?\"";

    for (unsigned int i = 0, slen = strlen(s); i < slen) ; ++i)
      {
      char c = s[i];
      short kscan = VkKeyScan(c);

      if (isupper(c) || strchr(CSpecialChar, c))
        {
        // send Shift key down
        keybd_event(VK_SHIFT, 1, 0, 0);
        // send char down
        keybd_event(kscan, 1, 0, 0);
        // send char up
        keybd_event(kscan, 1, KEYEVENTF_KEYUP, 0);
        // send Shift key up
        keybd_event(VK_SHIFT, 1, KEYEVENTF_KEYUP, 0);
        }
      else
        {
        // send char down
        keybd_event(kscan, 1, 0, 0);
        // send char up
        keybd_event(kscan, 1, KEYEVENTF_KEYUP, 0);
        }
      }
    }
  --------------

The strlen call and associated search for the end of the string is not
done in each iteration of the loop, just once at the beginning.

The value of 'i' is pre-incremented because the way it is used in the
loop is not in a post-incrementing manner.  (and yes, in his
examples Bjarne does post-increment instead of pre-increment
when post-increment is not needed and yes, Bjarne is wrong).
Let the compiler optimization work on what you did not think of.
One should write so that the generated code quality is only
dependent on the optimizer for those things he does not already
know about.

There is only one indexed fetch from the array in memory per
iteration of the loop instead of 3 or 4 times depending upon the
result of isupper.

The array indexing uses brackets, "s[i]", instead of the old
1980 C way of "*(s+i)'" so may be more easily understood.

There is only one call to VkKeyScan instead of two calls per loop
iteration and generated code for one call instead of for four calls.

.  Ed

> Rodolfo Frino wrote in message
> news:3f77017d@newsgroups.borland.com...
>
> ...With this function the code
> can be simplified as:
>
> void SendCString(const char* s)
> {
>     const char CSpecialChar[] = "!@#$%^&*()_+{}|:<>?\"";
>     for (unsigned int i=0; i < strlen(s) ; i++)
>     {
>         if (isupper(*(s+i)) || strchr(CSpecialChar, *(s+i)))
>         {
>             // send Shift key down
>             keybd_event(VK_SHIFT, 1, 0, 0);
>             // send char down
>             keybd_event(VkKeyScan(*(s+i)), 1, 0, 0);
>             // send char up
>             keybd_event(VkKeyScan(*(s+i)), 1, KEYEVENTF_KEYUP, 0);
>             // send Shift key up
>             keybd_event(VK_SHIFT, 1, KEYEVENTF_KEYUP, 0);
>         }
>         else
>         {
>             // send char down
>             keybd_event(VkKeyScan(*(s+i)), 1, 0, 0);
>             // send char up
>             keybd_event(VkKeyScan(*(s+i)), 1, KEYEVENTF_KEYUP, 0);
>         }
>     }
> }
>
>
> The property you refer to is a Label that I placed on the
> form at design-time. Well, I wanted to display the number
> of e-mails sent (MessageCount) on that Label, which must
> be on a Form, so I needed the form for that, and also to
> place a button to send the e-mail. Of course you could also
> do it without the Label and without the Button.
>
> I don't worry about the Labels/Buttons/etc. that are not declared
> anywhere, people will figure it out, and they will add them/drop
> them into their forms to run the example.