🚀 go-pugleaf

"Colin Maharaj" <cbm@cablenett.net> wrote in message
news:3F135784.B6BE9C00@cablenett.net...
>           if (BinAccess == NULL)
>           {
>             if (GetLastError() == ERROR_ALREADY_EXISTS)

If the mutex already existed, CreateMutex() will not return NULL.  It only
does that on a real error.  Your logic could be more like this instead:

    HANDLE BinAccess = CreateMutex(NULL, FALSE, "BinAccess");
    bool DidCreate = false
    if( (BinAccess) && (GetLastError() != ERROR_ALREADY_EXISTS) )
        DisCreate = true;

However...

>           if (DidCreate == true) CloseHandle(BinAccess);

You must always close any handles you obtain, whether you initially created
them or not.  So your logic to use DidCreate in the first place is wrong.
Get rid of it.

With that said, you should also not be creating/opening the mutex everything
time you want to wait on it, either.  You should be creating it *once* at
the very beginning and then reusing it over and over for the lifetime of the
thread or data (depending on your design), only closing it onoce you're
actually finished with it.


Gambit