🚀 go-pugleaf

Remy Lebeau (TeamB) wrote:
> You still didn't answer my other questions, though - what are the return
> values of RegQueryValueEx() and GetLastError() when the code is failing?

I'm very sorry, but I haven't checked GetLastError so far, maybe because 
it isn't mentioned in my version of Win32.HLP from www.activevb.de. 
RegQueryValueEx gave back a value != ERROR_SUCCESS, but I didn't checked 
it, too.
I'll try your example and mail my experience with it, when I'm home from 
a short holiday on friday.

>>If I call RegCloseKey when RegQueryEx failed, I got an acces violation.
> 
> Then I would suspect that you are corrupting your memory in general.  Your
> buffer is probably invalid, and you are probably overflowing it and writing
> into surrounding memory, which is probably writting over your HKEY handle as
> well.  Please post more complete code snippets.

Here you are: That are the main c file plus the header file for both the 
dll and the using exe:

/* win32shell.h */
/* general error codes
  */
#define NO_MEM		-10
/* error codes for getShellFolder()
  */
#define WRONG_KEY	-20

/* Global definitions of the shell folders for using in getShellFolder().
  * The annotations are valid if you installed Windows in the default
  * folders.
  */
#define AdministrativeTools	 1
#define AppData			 2	// %WINDIR%\AppData
#define Cache			 3	// %WINDIR%\Temporary Internet Files
#define Cookies			 4	// %WINDIR%\Cookies
#define Desktop			 5	// %WINDIR%\Desktop
#define Favorites		 6	// %WINDIR%\Favorites
#define Fonts			 7	// %WINDIR%\Fonts
#define History			 8	// %WINDIR%\History
#define LocalAppData		 9	// %WINDIR%\Local Settings\AppData
#define MyPictures		10	// My Documents\My Pictures
#define NetHood			11	// %WINDIR%\NetHood
#define Personal		12	// My Documents
#define PrintHood		13	// %WINDIR%\PrintHood
#define Programs		14	// %WINDIR%\Start Menu\Programs
#define Recent			15	// %WINDIR%\Recent
#define SendTo			16	// %WINDIR%\SendTo
#define StartMenu		17	// %WINDIR%\Start Menu
#define Startup			18	// %WINDIR%\Start Menu\Programs\Startup
#define Templates		19	// %WINDIR%\ShellNew

/* Here starts the section with the exported/imported function prototypes
  */
#ifdef __cplusplus
extern "C" {
#endif

#ifdef BUILD_DLL
#define DLL_CALL __declspec(dllexport)
#else
#define DLL_CALL __declspec(dllimport)
#endif

	DLL_CALL int __stdcall getShellFolder(int folder, char *buffer);

#ifdef __cplusplus
}
#endif

/* win32shell.c */
#include <windows.h>
#include <stdlib.h>

#include <stdio.h>	//D

#define BUILD_DLL
#include "win32shell.h"

const char *ShellFoldersKey = "Software\\Microsoft\\Windows\\"
		"CurrentVersion\\Explorer\\Shell Folders";

int __stdcall getShellFolder(int folder, char *buffer) {
	HKEY regh = NULL;
	LPDWORD buffsize = 0;
	int retval = 0;
	char *regkey;// = NULL;

	//if ((regkey = (char *) malloc(strlen(ShellFoldersKey) + 51)) == NULL)
	//	return NO_MEM;

	//strcpy(regkey, ShellFoldersKey);
	switch(folder) {
		case AdministrativeTools:
			//strcat(regkey, "Administrative Tools"); break;
			regkey = "Administrative Tools"; break;
		case AppData:	//strcat(regkey, "AppData"); break;
			regkey = "AppData"; break;
		case Cache:	//strcat(regkey, "Cache"); break;
			regkey = "Cache"; break;
		case Cookies:	//strcat(regkey, "Cookies"); break;
			regkey = "Cookies"; break;
		case Desktop:	//strcat(regkey, "Desktop"); break;
			regkey = "Desktop"; break;
		case Favorites:	//strcat(regkey, "Favorites"); break;
			regkey = "Favorites"; break;
		case Fonts:	//strcat(regkey, "Fonts"); break;
			regkey = "Fonts"; break;
		case History:	//strcat(regkey, "History"); break;
			regkey = "History"; break;
		case LocalAppData:
			//strcat(regkey, "Local AppData"); break;
			regkey = "Local AppData"; break;
		case MyPictures:
			//strcat(regkey, "My Pictures"); break;
			regkey = "My Pictures"; break;
		case NetHood:	//strcat(regkey, "NetHood"); break;
			regkey = "NetHood"; break;
		case Personal:	//strcat(regkey, "Personal"); break;
			regkey = "Personal"; break;
		case PrintHood:	//strcat(regkey, "PrintHood"); break;
			regkey = "PrintHood"; break;
		case Programs:	//strcat(regkey, "Programs"); break;
			regkey = "Programs"; break;
		case Recent:	//strcat(regkey, "Recent"); break;
			regkey = "Recent"; break;
		case SendTo:	//strcat(regkey, "SendTo"); break;
			regkey = "SendTo"; break;
		case StartMenu:	//strcat(regkey, "Start Menu"); break;
			regkey = "Start Menu"; break;
		case Startup:	//strcat(regkey, "Startup"); break;
			regkey = "Startup"; break;
		case Templates:	//strcat(regkey, "Templates"); break;
			regkey = "Templates"; break;
		default: return WRONG_KEY;
	}

	if (RegOpenKeyEx(HKEY_CURRENT_USER, ShellFoldersKey, 0,
				KEY_READ, &regh) == ERROR_SUCCESS)
	{
		//char msg[1024];

		//if (RegQueryValueEx(regh, regkey, NULL, NULL, NULL, buffsize)
		//		== ERROR_SUCCESS) {
		//	buffer = (char *) malloc((unsigned int) buffsize + 1);
		MessageBox(0, regkey, "Debug", MB_OK);
		if(	RegQueryValueEx(regh, regkey, NULL, NULL, buffer,
					buffsize + 1) == ERROR_SUCCESS) {
			RegCloseKey(regh);
			retval = 1;
		}
	}
	return retval;
}

Yours,
-- 
Robert Bienert <robertbienert@gmx.net>
Check also my free software at http://www.rbprogs.de.vu/