🚀 go-pugleaf

Remy Lebeau (TeamB) wrote:

>Why use assembly for that?  A simple loop would be easier to manage:

It is part of a memory manager, he wants it small and fast.

>    int BytesOK(unsigned char *pAddr, unsigned char bval, unsigned nbytes)
>    {
>        for(unsigned ui = 0; i < nbytes; ++i)
>        {
>            if( pAddr[ui] != bval )
>            {
>                if( !MM3AdminData.survivalmode )
>                {
>                    if( MM3AdminData.callint3onerror )
>                        __asm int 3 ;
>                    else
>                        return 0;
>                }
>                break;
>            }
>        }
>        return 1;
>    }

Your returns are backwards.
sb 1 for fail, 0 for ok.
if/else incorrect.
>    int BytesOK(unsigned char *pAddr, unsigned char bval, unsigned nbytes)
>    {
>        for(unsigned ui = 0; i < nbytes; ++i)
>        {
>            if( pAddr[ui] != bval )
>            {
>                if( !MM3AdminData.survivalmode )
>                {
>                    if( MM3AdminData.callint3onerror )
>                        __asm int 3 ;
>                }
                 return 1;
>            }
>        }
>        return 0;
>    }