🚀 go-pugleaf

Hi Remy,

Thank you very much for your quick answer.

> You did not say where it is failing.  Can you step through the code and 
> find the particular line that is not working?

The code does not enter the while loop in function FillTree:

//  while (lpeidl->Next(1, &lpidlCurrent, &ulFetched) == S_OK) {

void __fastcall TForm1::FirstTree(void)
{
  LPMALLOC lpMalloc;

  if (SUCCEEDED(SHGetMalloc(&lpMalloc))) {
   LPSHELLFOLDER lpsf;
   SHFILEINFO FileInfo;
   unsigned int uSHFlags = SHGFI_SYSICONINDEX | SHGFI_DISPLAYNAME | 
SHGFI_PIDL;
   TTreeNode *TNode;

   if (SUCCEEDED(SHGetDesktopFolder(&lpsf))) {
    LPITEMIDLIST lpidl;
    if (SUCCEEDED(SHGetFolderLocation(Handle, CSIDL_DRIVES, NULL, 0, 
&lpidl))) {
     LPSHELLFOLDER lpsfSub;
     if (SUCCEEDED(lpsf->BindToObject(lpidl, NULL, IID_IShellFolder, 
reinterpret_cast<void **>(&lpsfSub)))) {
      SHGetFileInfo((LPCSTR)lpidl, 0, &FileInfo, sizeof(SHFILEINFO), 
uSHFlags);
      FillTree(lpsfSub, lpidl);
      lpsfSub->Release();
     }
     else ErrorFunc();
    }
    else ErrorFunc();
    lpMalloc->Free(lpidl);
    lpsf->Release();
   }
   else ErrorFunc();
   lpMalloc->Release();
  }
  else ErrorFunc();
}
//---------------------------------------------------------------------------
void __fastcall TForm1::FillTree (LPSHELLFOLDER lpsf, LPITEMIDLIST lpidl)
{
  LPMALLOC lpMalloc;
  Screen->Cursor = crHourGlass;

  if (SUCCEEDED(SHGetMalloc(&lpMalloc))) {
   LPENUMIDLIST lpeidl;
   HRESULT HRes;

   HRes = lpsf->EnumObjects(NULL, SHCONTF_NONFOLDERS, &lpeidl);

   if (HRes == NOERROR) {
    TreeView1->Items->BeginUpdate();
    LPITEMIDLIST lpidlCurrent;
    unsigned long ulFetched;
    while (lpeidl->Next(1, &lpidlCurrent, &ulFetched) == S_OK) { //////// 
failing line
     LPITEMIDLIST lpidlFQ = MergeIDLists (lpMalloc, lpidl, lpidlCurrent);
     if (lpidlFQ) {
      SHFILEINFO FileInfo;
      DWORD FileAttrib;
      unsigned int uSHFlags;
      TTreeNode *Node;
      uSHFlags = SHGFI_SYSICONINDEX | SHGFI_DISPLAYNAME | SHGFI_PIDL;
      SHGetFileInfo(reinterpret_cast<LPCSTR>(lpidlFQ), FileAttrib, 
&FileInfo, sizeof(SHFILEINFO), uSHFlags);

      Node = TreeView1->Items->AddChild(NULL, FileInfo.szDisplayName);
      Node->ImageIndex = FileInfo.iIcon;
      Node->SelectedIndex = FileInfo.iIcon;
      Node->Data = reinterpret_cast<void *>(lpidlFQ);
      TTreeNode *ChildNode = TreeView1->Items->AddChild(Node, "");
      ChildNode->ImageIndex = -1;
     }
     lpMalloc->Free(lpidlCurrent);
    }
    ErrorFunc();
    TreeView1->Items->EndUpdate();

    lpeidl->Release();
   }
   else {
    ErrorFunc();
   }
   lpMalloc->Release();
  }
  else {
 Screen->Cursor = crArrow;
 ErrorFunc();
  }
  Screen->Cursor = crArrow;
}
//---------------------------------------------------------------------------
void __fastcall TForm1::ErrorFunc (void)
{
  LPTSTR MsgBuf;

  FormatMessage (FORMAT_MESSAGE_ALLOCATE_BUFFER | 
FORMAT_MESSAGE_FROM_SYSTEM, NULL,
     GetLastError(), MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT),
     (LPTSTR) &MsgBuf, 0, NULL);

  MessageBox (NULL, MsgBuf, "Error Message", MB_OK|MB_ICONINFORMATION);
  LocalFree (MsgBuf);
}
//-----------------------------------------------------------------------------

> Have you tried using Vista's new KNOWNFOLDERIDs instead of CSIDLs?  In 
> this case, CSIDL_DRIVES maps to FOLDERID_ComputerFolder.  Have a look at 
> MSDN for more details:
>
>    Known Folders
>    http://msdn.microsoft.com/en-us/library/bb776911(VS.85).aspx

Thanks for the tip. I think it requires Vista SDK. I have download and 
installed it. I have begun studying on KNOWNFOLDERID.