🚀 go-pugleaf

"Dan Mayo" <do_not_spam_dmayo2@netzero.com> wrote in message
news:45cba995$1@newsgroups.borland.com...

> Ok, I have went thru all of my code and have changed to auto_ptrs
for
> the most part; and in places where I still need to use the pointer,
I
> have been sure to initialize it so that I don't attempt to delete a
> pointer that hasn't been initialized.

You shouldn't be deleting anything when using auto_ptr.  That is the
whole point of auto_ptr - it frees the object for you automatically.

> std::auto_ptr<TSubForm> newform(TSubForm(this));

That is not a valid statement.  You can't create VCL objects on the
stack.  Perhaps you meant to call the 'new' operator instead?

    std::auto_ptr<TSubForm> newform(new TSubForm(this));

> On a side note, is the following valid?

Yes (after you fix the above bug), though I would sggest you use the
auto_ptr's get() method instead:

    void function()
    {
        std::auto_ptr<TSubForm> form(new TSubForm(NULL));
        SubFormICanReferenceSomewhereElse = form.get(); // <--
        DoSomething();
        SubFormICanReferenceSomewhereElse = NULL;
    }

Of course, if DoSomething() throws an exception, then
SubFormICanReferenceSomewhereElse will not be reset to NULL, though
the TForm will have been freed.  You would need an exception handler
to ensure it gets reset correctly:

    void function()
    {
        std::auto_ptr<TSubForm> form(new TSubForm(this));
        SubFormICanReferenceSomewhereElse = form.get();
        try
        {
            DoSomething();
        }
        catch(...)
        {
        }
        SubFormICanReferenceSomewhereElse = NULL;
    }

It would be better to pass the TForm pointer as a parameter instead of
using a global:

    void DoSomething(TSubForm *Form)
    {
        if( Form )
            // do something with the Form
    }

    void function()
    {
        std::auto_ptr<TSubForm> form(new TSubForm(NULL));
        DoSomething(form.get());
    }


Gambit