🚀 go-pugleaf

Hay all, posted a message the other day regarding a bug I was chasing that I 
though was cause by a call to CoInitialize.  Tracked it down and it has 
nothing to do with it.

After careful delving, I found that the EAccessViolation error is stemming 
from some code used to display the default system language.  The exception 
is raised when I either try to get a point to the global TLanguage object or 
dynamically creating a new one.  It currently only seem to occur when the 
code / GINA is run on Windows systems that has English (United States), LCID 
0x0409, as there default system language.  It does not happen on English 
(UK) or any other European locales.

Please note that the GINA / my code is running under the winlogon desktop 
and LOCAL_SYSTEM.

The other anomaly is that if I extract the below code, and sick it in a demo 
application and run that on the users desktop, it functions correctly:

TLanguages *lang = NULL;
try
{
   try
   {
      lang = new TLanguages();    //*******<- point of exception
      //lang = Languages();            //****** either option cause 
excpetion

      LCID udlc = GetSystemDefaultLCID();
      for (short i=0; i<lang->Count; ++i)
      {
          if (lang->LocaleID[i] == udlc)
          {
             panSysLang->Caption = lang->Ext[i].SubString(0, 2);
             panSysLang->Hint = 
GinaStub->RtnSz(HELP_OPT_CONFIG_HEADER_SYS_LANG_HINT);
             panSysLang->Hint = 
AnsiString().sprintf(panSysLang->Hint.c_str(), lang->Name[i].c_str());
          }
      }
   }
   catch (std::bad_alloc)
   {
   }
}
__finally
{
   if (lang)
   {
      delete lang;
       lang = NULL;
   }
}