🚀 go-pugleaf

Mike Collins wrote:

>Image->Picture->Icon->Handle      = LoadImage(hDLL, MAKEINTRESOURCE(12), 
>IMAGE_ICON, 32, 32, LR_DEFAULTSIZE);

It doesn't sound like LR_DEFAULTSIZE is compatable with 32,32.
You are asking for exclusive 32,32 icons.
If you used 0,0 with LR_DEFAULTSIZE, you would get 16,16 or SM_CXICON
If you used 0,0 *Without* LR_DEFAULTSIZE, you would get whatever is
available.


>- is it necessary to free the handle that is returned from LoadImage using 
>DestroyIcon?  I never seem any reference to this when i've seen BCB examples 
>and i've never had any resource leaks reported...

No, but its nice to do. From MSDN:

When you are finished using a bitmap, cursor, or icon you loaded
without specifying the LR_SHARED flag, you can release its associated
memory by calling one of the functions in the following table. 
The system automatically deletes these resources when the process that
created them terminates; however, calling the appropriate function
saves memory and decreases the size of the process's working set.

So, not a leak, but uses more memory until freed.

>Secondly, is there any advantage to using LoadImage api over ExtractIcon? 

LoadImage has more options. And can share loaded resources. And can
select best-fit images from multi-size/colordepth icons.
ExtractIcon has no options nor "best-fit".

> To avoid any possible copyright issues,

To avoid copyright issues, make your own icons.

> However, LoadImage seems to fail if i try 
>to load an icon that has an Id grater than 56.

Mine stops at 54 (XP home, SP2)

ExtractIcon works for the full number of icons.

If anyone wants to play with it, compile as console app.
To switch from ExtractIcon to LoadImage, uncomment the 4 lines, and
comment the ExtractIcon.

#include	<windows.h>
	extern	HINSTANCE	_hInstance;	// global in c0x32
/* ---------------------------------------------------------------- */
void _stdcall ErrorBox( HWND hWnd, DWORD errorcode,LPCTSTR titl)
{	VOID* lpBuffer;
	FormatMessage(
FORMAT_MESSAGE_ALLOCATE_BUFFER+FORMAT_MESSAGE_FROM_SYSTEM+70,
		NULL,errorcode,0,(char*)&lpBuffer,0,NULL);
	MessageBox( hWnd, (char*)lpBuffer, titl,
		 MB_OK|MB_ICONINFORMATION|MB_TOPMOST );
	LocalFree( lpBuffer );
}
/* ---------------------------------------------------------------- */
int main(void)
{
    int	i;
    int	max = (int)ExtractIcon( _hInstance,
			"C:\\Windows\\system32\\shell32.dll", -1 );
    HICON	hIcon;
    HWND	hWnd = 0;
    char	msg[1024];
//  HMODULE	hMod = GetModuleHandle(
//			 "C:\\Windows\\system32\\shell32.dll" );
    for( i = 1; i <= max; ++i )
    {
//	hIcon = LoadImage( hMod, MAKEINTRESOURCE(i), IMAGE_ICON,
//			 0,0, LR_DEFAULTCOLOR | LR_SHARED );
	hIcon = ExtractIcon( _hInstance,
		 "C:\\Windows\\system32\\shell32.dll", i );
	if( (int)hIcon > 1 )
	{
		wsprintf( msg, "\r\nIcon Test #%i of %i\r\n", i, max);
		ShellAbout ( hWnd, "Icon Tester#About IconTest",
// title bar and first line text
			msg,	// other dialog text
			hIcon ); 	// icon to display
		DestroyIcon( hIcon );
	}else{
		ErrorBox( hWnd, GetLastError(), "LoadImage Error" );
	};
    };
    return 0;
}