🚀 go-pugleaf

Mike Collins wrote:

>  My code is pretty straightforward (as shown below) but it seems to to 
>failing on the GetProcAddress.  Can anyone see where i'm going wrong:

You don't report failure to load the library.
Add failure code to show the szWNetPath.


>   // Dynamically Load WinINet.dll...
>   AnsiString szWINetPath = "";
>   szWINetPath.SetLength(MAX_PATH+1);

>   szWINetPath.SetLength(GetSystemDirectory(szWINetPath.c_str(), 
>szWINetPath.Length()));

I find that line confusing.
Also not sure if length isn't calculated before GetSystemDirectory
sets it?
Also, since everything in here uses cstrings, why not use cstrings
instead complicating things with  AnsiString?

	char  szWINetPath[MAX_PATH+1];
	GetSystemDirectory( szWINetPath,  MAX_PATH);
	lstrcat( szWINetPath, "\\wininet.dll");
	hINetDLL = LoadLibrary(szWINetPath);

	But, I'd prefer this:
	hINetDLL = LoadLibrary("wininet.dll");

BTW#2: AnsiString isn't an sz. Probably an 'as' or plain 's'.

>   szWINetPath = AnsiString(szWINetPath + "\\wininet.dll");
>   hINetDLL = LoadLibrary(szWINetPath.c_str());



>   // If ineternet connection established, then close it...
>   if (hINetHnd)
>      InternetCloseHandle(hINetHnd);
>
>   if (hINetDLL)
>      FreeLibrary(hINetDLL);

Proper use of flow control will eliminated those extra if()s at the
end...

   if (hINetDLL)
   {
         if (hINetHnd)
         {
	// use the internet
	// .....

	InternetCloseHandle(hINetHnd);
        }else{
	// handle hNet failure
         };

         FreeLibrary(hINetDLL);
   }else{
	//handle dll failure
   };