🚀 go-pugleaf

Renald Yazmir wrote:

>This function causing a software crash when I resize a window or move a 
>dialog box over the picture.
>LoadBitmap returns NULL.
>
>What is wrong with this function?

Not sure, could be a problem with the caller,
but will highlight some points...

>void draw_transparent_picture(
>     HWND hwnd,
>     int pictid,
>     RECT *rct,
>     COLORREF transparent_color
>     )
>{
> BITMAP bitmap;
> COLORREF crOldBack   = 0;

0 is never used.

> HDC dcImage     = NULL;
> HDC dcTrans     = NULL;
> HBITMAP pOldBitmapImage  = NULL;
> HBITMAP bitmapTrans   = NULL;
> HBITMAP pOldBitmapTrans  = NULL;
> HBITMAP hBitmap    = NULL;
> HDC hDC      = NULL;
> HDC hMemDC     = NULL;

All those NULLs are never used.

> hDC = GetDC(hwnd);
>
> if ((hMemDC = CreateCompatibleDC(hDC)) == (HDC) NULL)
>  return;

You didn't release the hDC.

> hBitmap = LoadBitmap(res_lib, MAKEINTRESOURCE(pictid));// load from 
>resource dll
>
> if (hBitmap == NULL)
>  return;

You didn't delete the hMemDC
You didn't release the hDC.

> crOldBack = SetBkColor(hDC, RGB(255, 255, 255));
>
> // Create two memory dcs for the image and the mask
> dcImage=CreateCompatibleDC(hDC);
> dcTrans=CreateCompatibleDC(hDC);

You don't check those HDCs.