🚀 go-pugleaf

Anders Johansen wrote:

>The code below has a potential flaw: The callback code is 
>running in the main thread, and so may block the system event
>processing or at least delay it.

The only slow part in the hooks I can see is notifyKeyDown,
and it's reliance on virtual KeyDown functions.
Everything else should be quite fast enough.

Two thoughts on notifyKeyDown:

1) You use "set" with pointers, apparently ordered by address.
I would think "vector" would be more appropriate.

2) You could place notifyKeyDown in a thread and have
the hooks place data in a FIFO for the thread to consume.

void notifyKeyDown(const UINT vkey, const bool altDown)
{	ThreadStruct.vkey = vkey;
	ThreadStruct.altDown = alt.Down;
	Fifo.Push( ThreadStruct );
	Thread.Resume();
}

>>void HookMaster::notifyKeyDown(const UINT vkey, const bool altDown) {
>>  for (std::set<HookObserver*>::iterator i = observers.begin(); i != observers.end(); ++i) {
>>    try {
>>      HookObserver *obs = *i;
>>      obs->keyDown(vkey, altDown, keyDownNumber);
>>    } catch (...) {
>>      // Something bad happened with the observer
>>    }
>>  }
>>  ++keyDownNumber;
>>}