🚀 go-pugleaf

"Mike Collins" <its@TheBottomOfThePost.com> wrote in message
news:44628b1d$1@newsgroups.borland.com...

> I've never had to make this call directly when i've used the
> TCppWebBrowser before though.

Under many situations, CoInitialize() gets called automatically during
application startup.

> I trying to work out the best place to place these two calls
> CoInitialize() and CoUninitialize().

The best place is at the beginning/end of the calling thread.  However,
since your code is in a DLL, the calling application controls the threads
that call into the DLL, so the application should be calling CoInitialize()
before then calling your DLL.

>          if (CoInitialize(NULL)==S_OK)

CoInitialize() can also return S_FALSE instead of S_OK.  S_FALSE is not an
error.  You should be using the SUCCEEDED() macro instead of testing for
S_OK specifically.

>    __finally

The order is you catch and __finally blocks is a bit wrong.  Use this
instead:

    try
    {
        if( SUCCEEDED(CoInitialize(NULL)) )
        {
            try
            {
                HelpOptDlg = new THelpOptDlg(NULL);
                try {
                    iRtn = HelpOptDlg->ShowModal();
                }
                __finally
                {
                    delete HelpOptDlg;
                    HelpOptDlg = NULL;
                }
            }
            __finally
            {
                CoUninitialize();
            }
        }
        else
            // error...
    }
    catch (const Exception &exception)
    {
        MessageBox(NULL, exception.Message.c_str(), "TCppWebBrowser
Exception", MB_OK|MB_ICONERROR|MB_TOPMOST);
    }

> is it better to call it "globally" when the DLL first starts up i.e. in
DLLMain?

CoInitialize() has to be called on a per-thread basis.  Although DllMain()
is called whenever the DLL is loaded into a particular thread, you have to
be careful because DLL_THREAD_ATTACH is not triggered for existing threads
when the DLL is loaded by LoadLibrary().


Gambit