🚀 go-pugleaf

Chris,

Have you tried to read back the registry entries immediately after writing 
them?  Perhaps they're not really getting written.

I do have a tiny suggestion about memory management for you.  It is 
advantageous for a C++ programmer to use the STL class "std::auto_ptr" to 
handle the destruction of a pointer that has been allocated on the heap.  It 
simplifies code and is exception safe which means that you don't have to 
code try...catch or try...finally blocks just to handle memory.  Here is 
your code modified to use auto_ptr.

  #include <memory> // this is where auto_ptr is

  String __fastcall TfrmServerAdmin::MyGetRegVal(String  KeyToOpen,
    String KeyToRead, String & Default, int RootKey)
  {
    TRegistry *thisreg = new TRegistry;
    std::auto_ptr<TRegistry> auto_thisreg(thisreg);
    thisreg->RootKey =  (void*)RootKey; // Registry Section
    if (thisreg->OpenKeyReadOnly(KeyToOpen))
      if (thisreg->ValueExists(KeyToRead))
        return thisreg->ReadString(KeyToRead);
    return Default;
  }

  bool __fastcall TfrmServerAdmin::SetRegVal(String  KeyToOpen,
    String KeyToWrite, String & StrToWrite, bool CreateKey,
    int RootKey)
  {
    TRegistry *thisreg = new TRegistry;
    std::auto_ptr<TRegistry> auto_thisreg(thisreg);
    thisreg->RootKey = (void*)RootKey; // Registry Section
    if (thisreg->OpenKey(KeyToOpen,CreateKey))
    {
      thisreg->WriteString(KeyToWrite,StrToWrite);
      return true;
    }
    return false;
  }

  bool __fastcall TfrmServerAdmin::DeleteRegVal(String  KeyToOpen,
    String KeyToDelete, int RootKey)
  {
    TRegistry *thisreg = new TRegistry;
    std::auto_ptr<TRegistry> auto_thisreg(thisreg);
    thisreg->RootKey = (void*)RootKey; // Registry Section
    return
      thisreg->OpenKey(KeyToOpen,false) &&
      thisreg->DeleteValue(KeyToDelete);
  }

Another suggestion.  The 'RootKey' parameter is type HKEY.  Why not specify 
that in your argument list instead of "int" to avoid confusion?

- Clayton