🚀 go-pugleaf

Kris <x.y@xyz.xx> wrote:
>
> [...] problems integrating your TrayIcon
<snip>
>void __fastcall TMainForm::FormCreate(TObject *Sender) 

Never use the OnCreate or OnDestroy events. They are Delphi
remnants and as such can execute out of order. Use the
constructor and destructor instead. For the destructor, you
need to prototype it in the header. For example:

    public:  // User declarations
        __fastcall TForm1(TComponent* Owner); // don't duplicate
        __fastcall ~TForm1();
    
//-------------------------------------------------------------
__fastcall TForm1::TForm1(TComponent* Owner) : TForm(Owner)
{
    // initialization code here
}
//-------------------------------------------------------------
__fastcall TForm1::~TForm1()
{
    // clean-up code here
}
//-------------------------------------------------------------

>Following error code is executed when I run it : 
>   if( FParentForm != Application->MainForm ) 
>   { 
>      MessageDlg( "TAnimatedTrayIcon can only be placed on the Main
>Form.", mtError, TMsgDlgButtons() << mbOK, 0 ); 
>      Application->Terminate(); 
>   }

The only way that that block of code is reached is if the
main form is not the Owner of the object (which I see that it
is) or if the Application::MainForm has not been set yet as a
result of the constructor not finishing. I used PostMessage to
delay that if-block until MainForm was valid but it appears
that OnCreate is mucking it up.

<snip>

All of the problems that you describe are in my mind a direct
result of using OnCreate.

> I've disabled my own code as much as possible in the
> FormCreate/FormClose 

FormClose is not guaranteed to execute and if it's used for
clean-up can cause problems. Use the destructor instead.

~ JD