🚀 go-pugleaf

"Kris" <x@x.com> wrote in message news:47d8ec90$1@newsgroups.borland.com...

> Do I have to take care of freeing that memory

Yes.

> is someone else taking care of freeing the STRRET.pOleStr
> (e.g. pDesktopFolder) ?

No.

> Probably safe to assume STRRET_WSTR is set in this specific case
> So simply use the pOleStr member without any additional checks

You cannot assume that.  You need to look at the STRRET's uType parameter to 
know exactly how to interpret the STRRET's contents properly, for example:

    switch( sName.uType )
    {
        case STRRET_CSTR
            DEBUG("DisplayNameof(CSIDL_PERSONAL)=[%s]", sName.cStr);
            break;
        case STRRET_OFFSET:
        {
            char *pName = (char*)(((LPBYTE)pidl) + sName.uOffset);
            DEBUG("DisplayNameof(CSIDL_PERSONAL)=[%s]", pName);
            break;
        }
        case STRRET_WSTR:
        {
            // assuming DEBUG() is based on printf() or similar function...
            DEBUG("DisplayNameof(CSIDL_PERSONAL)=[%ls]", sName.pOleStr);
            CoTaskMemFree(sName.pOleStr);
            break;
        }
    }

Alternatively, you can use one of the StrRetTo...() functions instead, which 
also handle freeing the STRRET_WSTR memory for you, ie:


    TCHAR szBuf[MAX_PATH+1] = {0};
    StrRetToBuf(&sName, pidl, szBuf, MAX_PATH+1);

    #ifdef UNICODE
    DEBUG("DisplayNameof(CSIDL_PERSONAL)=[%ls]", szBuf);
    #else
    DEBUG("DisplayNameof(CSIDL_PERSONAL)=[%s]", szBuf);
    #endif

Or:

    LPTSTR pName;
    StrRetToStr(&sName, pidl, &pName);

    #ifdef UNICODE
    DEBUG("DisplayNameof(CSIDL_PERSONAL)=[%ls]", szBuf);
    #else
    DEBUG("DisplayNameof(CSIDL_PERSONAL)=[%s]", szBuf);
    #endif

    CoTaskMemFree(pName);

Or:

    WideString wName;
    StrRetToBSTR(&sName, pidl, &wName);

    DEBUG("DisplayNameof(CSIDL_PERSONAL)=[%ls]", wName.c_bstr());


Gambit